Comments (5)
Thanks for raising the issue! Yes, this will require some work. Also will have to check if the suggested changes are backwards compatible with shapely versions prior 1.8.0
from topojson.
Maybe you can put upper limits on dependency versions? https://github.com/mattijn/topojson/blob/master/pyproject.toml#L17
from topojson.
Logging to self:
from shapely import geometry
feat = {
"type": "Feature",
"geometry": {"type": "LineString", "coordinates": [[0.1, 0.2], [0.3, 0.4]]},
}
geometry.shape(feat)
/Users/mattijnvanhoek/miniconda3/lib/python3.9/site-packages/shapely/geometry/geo.py:123: ShapelyDeprecationWarning: GeometryTypeError will derive from ShapelyError and not TypeError or ValueError in Shapely 2.0. raise GeometryTypeError("Unknown geometry type: %s" % geom_type) --------------------------------------------------------------------------- GeometryTypeError Traceback (most recent call last) /var/folders/2c/mjc91yxs03s45rz21c8crzv40000gn/T/ipykernel_12563/2908707415.py in <module> 5 } 6 ----> 7 geometry.shape(feat) ~/miniconda3/lib/python3.9/site-packages/shapely/geometry/geo.py in shape(context) 121 return GeometryCollection(geoms) 122 else: --> 123 raise GeometryTypeError("Unknown geometry type: %s" % geom_type) 124 125 GeometryTypeError: Unknown geometry type: feature
I include a from shapely.errors import ShapelyError
and catch this error as well now (5e7bc72), but I do not think this will make the warning disappear until shapely 2.0
from topojson.
I still have more warning stating the following:
<__array_function__ internals>:5: ShapelyDeprecationWarning: The array interface is deprecated and will no longer work in Shapely 2.0. Convert the '.coords' to a numpy array instead.
Where is this <__array_function__ internals>:5
located π€?? Not sure how to approach this one.
from topojson.
With PR #158 all code creating deprecation warnings are changed. Current master holds no warnings anymore for the test suite. Thanks for posting this issue, but I'm closing itπ.
from topojson.
Related Issues (20)
- tp.Topology.to_json(pretty=True) doesn't handle None correctly. (Doens't convert None to null) HOT 1
- Converting GeoJSON FeatureCollection to TopoJSON HOT 1
- BUG: `Topology.to_gdf` should keep the original index HOT 2
- holes in multipolygons are lost by simplification HOT 4
- Deprecation warning for shapely 2.0 HOT 3
- Wrong topologies/arcs being created? HOT 7
- Creating a topology for data without junctions and shared_coords=False, prequantize=False gives error
- Bug: polygons that entirely fill islands in another polygon are often not dedupped
- shared_coords=True vs shared_coords=False HOT 5
- Linestrings that follow the same path but where one contains extra redundant points are not deduplicated
- enh: include features that are possible with shapely 2.0
- tests failing, natural earth dataset changed HOT 2
- RuntimeWarning: invalid value encountered in cast HOT 3
- IndexError: pop index out of range when instanciating Topology with a list of GeoDataFrame HOT 10
- Coordinates not reported correctly on Multipoint with only one point HOT 2
- Excessive memory usage with prequantization enabled HOT 5
- serialize_as_geojson outputs invalid GeoJSON HOT 2
- Topojson >=1.6 requires Python >=3.8, but there is no guard against Python <3.8 HOT 2
- Feature: Use geojson feature/geometry id if exists HOT 4
- Converting TopoJson to a GeoJSon object_name not changing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from topojson.