Comments (4)
for (auto const& terminal : POSSIBLE_TERMINALS)
{
if (external_client_launcher.launch({terminal}) > 0)
break;
}
Doesn't do what you think. external_client_launcher.launch()
does a fork()/exec()
and returns the pid of the forked process. The fork()
will always succeed, even if the exec()
doesn't.
The approach I took with Miriway was to allow the user to configure the terminal command (and provide a fallback to a script that tries to identify an installed terminal).
from miracle-wm.
Doesn't do what you think.
external_client_launcher.launch()
does afork()/exec()
and returns the pid of the forked process. Thefork()
will always succeed, even if theexec()
doesn't.
Oh that's unfortunate
The approach I took with Miriway was to allow the user to configure the terminal command (and provide a fallback to a script that tries to identify an installed terminal).
I think that I will follow this same approach
from miracle-wm.
Hi agan @OPNA2608 👋 Would you give this PR try when you get a chance: #40
It should work in both a snap and non-snap context. You should be able to install the AMD snap from this page: https://github.com/mattkae/miracle-wm/actions/runs/8038897957?pr=40. I'll add the fix to a release/0.1.1
later this week if all is good.
Thanks for finding the bug!
from miracle-wm.
Also, I am testing out #39 now. I will cherry-pick it into release/0.1.1
alongside the terminal fix once approved 👍
from miracle-wm.
Related Issues (20)
- Automagic config reloading isn't threadsafe HOT 1
- Build a mechanism in Mir to allow our YAML configuration to be the primary configuration from which boost args are parsed
- Outer gaps do not reload when the configuration reloads
- Windows choose their own size too aggressively, which causes them to be smaller than the tile size
- Crashing after using the compositor for ~30minutes
- Confusing terminology in docs and config file HOT 4
- Suggestion: stick closer to existing Ubuntu standards? HOT 4
- [Q]: Focus stealing prevention feature HOT 12
- Firefox often decides to fullscreen itself, much to the chagrin of miracle
- Floating windows cannot be resized
- Fullscreen windows are being resized when a new window joins the tiling grid
- I3 IPC is a bit racy (e.g. workspaces can change while they're being sent)
- Add support for parent window selection
- Create a "miracle-certified" configuration that can provide a solid desktop experience without any extra work HOT 1
- [Q]: Can a WM positively affect the responsiveness of a system at low-memory state? HOT 6
- Upgrade to core24 so that the snap workflows function again
- Border rendering is throwing a GLError 1281
- When a window is moved such that a new root node is created, we disrespect exclusion zones
- The configuration system needs better, more meaningful errors with line and column indicators
- Generate enum configuration values using a python tool built on llvm
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miracle-wm.