Giter Site home page Giter Site logo

Comments (5)

creativenull avatar creativenull commented on June 21, 2024 1

There is some confusion here. formatStdin dictates how the input will be sent to the cli tool. Will it be from stdin? Or will it be handled externally (like pass in the filename/filepath)? This works as expected.

I think what you are referring to is to somehow control stdout that is passed back to the LSP client.

I think what is needed is something similar to lintIgnoreExitCode like formatIgnoreStdout if the cli tool does not support outputting the changes to stdout then just ignore them.

from efm-langserver.

mattn avatar mattn commented on June 21, 2024 1

Some linter/formatter command looks current directory, file name, file extension, or configuration files. So temporary file might not fix something.

from efm-langserver.

davidosomething avatar davidosomething commented on June 21, 2024

e.g. how null-ls creates a temporary buffer:
https://github.com/jose-elias-alvarez/null-ls.nvim/blob/main/lua/null-ls/formatting.lua

from efm-langserver.

chrisgrieser avatar chrisgrieser commented on June 21, 2024

yes please 🙏

There are a bunch of formatters/linters with auto-fix which do not work with stdin. Of the top of my head:

  • codespell
  • markdownlint
  • shellcheck (with the git apply workaround)

from efm-langserver.

creativenull avatar creativenull commented on June 21, 2024

However I don't see the LSP server like efm provide a way to channel these changes from a temp file to stdout.

I think it's the LSP client's responsibility to make sure the changes are shown if done externally just like it was done from stdout.

For vim/neovim we have :edit! to reload the buffer if the file changed outside of neovim but is kinda hacky but is the only way I know to see these changes.

from efm-langserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.