Giter Site home page Giter Site logo

[report] I think this is a bug. about cotatron HOT 2 OPEN

CODEJIN avatar CODEJIN commented on August 24, 2024
[report] I think this is a bug.

from cotatron.

Comments (2)

seungwonpark avatar seungwonpark commented on August 24, 2024

What a big mistake. Thanks for letting me know about this!

You're right and the depth parameter should be hp.depth.prenet here. So eventually the PreNet MLP was deeper than it originally had to be. (Intended 80->256->256 but was 80->256->256->256)

Typically, being a deeper model than intended won't affect the performance of the network much. However, in this case I think it might have changed some train-time behavior. I cannot guess whether it had positive/negative effect on the performance, so users might want to fix this error before training, or simply use the code with an error.

@wookladin Could you please pin this issue? Making a bugfix commit will break the pre-trained model, and apparently we don't have a budget for re-training the model. So we'd better make sure that the users to become aware of this bug, while acknowledging Heejo for reporting this issue.

@CODEJIN fyi I don't have a write access to this repo so I'm asking Kang-wook to do something for this repo.

from cotatron.

wookladin avatar wookladin commented on August 24, 2024

I pinned this issue. Thanks for letting us know!

from cotatron.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.