Comments (2)
What a big mistake. Thanks for letting me know about this!
You're right and the depth
parameter should be hp.depth.prenet
here. So eventually the PreNet MLP was deeper than it originally had to be. (Intended 80->256->256 but was 80->256->256->256)
Typically, being a deeper model than intended won't affect the performance of the network much. However, in this case I think it might have changed some train-time behavior. I cannot guess whether it had positive/negative effect on the performance, so users might want to fix this error before training, or simply use the code with an error.
@wookladin Could you please pin this issue? Making a bugfix commit will break the pre-trained model, and apparently we don't have a budget for re-training the model. So we'd better make sure that the users to become aware of this bug, while acknowledging Heejo for reporting this issue.
@CODEJIN fyi I don't have a write access to this repo so I'm asking Kang-wook to do something for this repo.
from cotatron.
I pinned this issue. Thanks for letting us know!
from cotatron.
Related Issues (17)
- Release of pre-trained weights for Cotatron & MelGAN HOT 1
- pytorch_lightning.utilities.exceptions.MisconfigurationException HOT 2
- Pretrained-model yet? HOT 2
- 한국어 dataset 에 관한 recipe / korean dataset model HOT 2
- Single Target Speaker HOT 3
- One-shot Conversion HOT 6
- Is need text in training corpus or only wav files? HOT 4
- Make train: raise ValueError('value should be one of int, float, str, bool, or torch.Tensor') HOT 3
- Adaptation for a corpus in Urdu HOT 1
- Question on use WaveGlow instead of MelGan HOT 1
- does this work to imitate anyone's voice? HOT 1
- How do I use the pretrained model for training Cotatron? HOT 8
- Clarification regarding the configuration of the MelGAN model HOT 2
- What change need make to compatible with Hi-fi GAN? HOT 5
- re-training n+1 speakers
- ConfigAttributeError: Missing key mask_padding
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cotatron.