Function value for `keys` not working as expected

[max397574]

Function value for `keys` not working as expected

[max397574]

It's not possible to run the function before. Because the function could be something that should be done after jk are deleted. I guess you could just use <ESC>and not a function and it should work for you.

[max397574]

@lucasvianav
added it on the dev branch

you can try
keys_before_delete = true,
in the setttings

[max397574]

I think ik what happens but not why

						*i_CTRL-E*
CTRL-E		Insert the character which is below the cursor.

if you type jk you no longer get completion propositions so there is no completition menu so c-e does it's default thing (see above)
that's where the [n] comes from

that pumvisible()'s output is 0 doesn't make sense to me. (what completion plugin do you use)
I could imagine that it has sth todo with that you don't get completions after deleting chars but only after entering
because you enter jkand then they get deleted
I just don't know why <c-e><ESC>gets executed and not <ESC>only
I'll look at it next week

[max397574]

okay it's actually simple

pumvisible()returns 0 if there is no popupmenu

0 is evaluated as true in lua

[lucasvianav]

pumvisible()returns 0 if there is no popupmenu

wow, I totally forgot to == 0 it. thanks :)

if you type jk you no longer get completion propositions so there is no completition menu so c-e does it's default thing (see above)

what do you mean? what I'm trying to solve is that when I have a completion option selected, if I just pres jk it'll confirm the completion before escaping insert mode.

If i do ino <silent><expr> jk pumvisible() ? "\<C-e><Esc>" : "\<Esc>" it works --- just escapes insert mode without confirming the completion.

I'm using coq_nvim btw

[lucasvianav]

I've added the == 0 now. Sometimes pumvisible() will return 1, other times 0, regardless if the pum is actually visible or not. I tried changing my config to:

keys = function()
    local selected = vim.fn.complete_info({ 'selected' }).selected
    return selected ~= -1 and '<C-e><Esc>' or '<Esc>'
end

But selected is always -1, even when I do have a completion option enabled

[max397574]

Actually the plugin (with the first config you sent) checks whether there is a pum after deleting the j and k

so it's the same like when you slowly type jk
can you check if there is a pum then?

[lucasvianav]

Yeah, when mapping jk directly the pum is still visible when the expression is evaluated. Look at the gifs below.

Here's the function I've used:

function! Test() abort
    echom complete_info()
    return pumvisible() ? "\<C-e>\<Esc>" : "\<Esc>"
endfunction

" ino <silent><expr> jk pumvisible() ? "\<C-e><Esc>" : "\<Esc>"
ino <expr> jk Test()

Would it be bad to run the keys function before deleting jk? Or maybe expose an option for the user to choose.

[max397574]

This would be possible
But I have to try if it doesn't break anything first
I'll ping you as soon as it's on the dev branch so you can test

[lucasvianav]

Wouldn't it be possible to expose the option of running the function either before or after?

[max397574]

I think it would be. I'll look at it next week.

[lucasvianav]

I think it would be. I'll look at it next week.

Alright, thanks :)

[lucasvianav]

thanks @max397574! I was about to test it, but I think there's a typo

Error detected while processing InsertCharPre Autocommands for "*":
E5108: Error executing lua ...pack/packer/opt/better-escape.nvim/lua/better_escape.lua:53: attempt to index global 'settigns' (a nil value)
Press ENTER or type command to continue

[lucasvianav]

I fixed the typo and tried it, but feeding <BS><BS> after exiting to normal mode goes back 2 chars (even sending me some lines up if I'm at the start of line). I'm not able to record a GIF right now tho

I also tried running a function both before and after jk is deleted (see below) -- the idea was to feed <C-e> before if needed and only leave insert mode after deleting jk. But it also doesn't work, for some reason the function isn't always able to detect that the pum is visible nor that there's an option selected, I couldn't figure out why.

[max397574]

doesn't this work if you just use no function?
for me it does

Screen.Recording.2021-10-15.at.18.02.10.mov

executing the function before the deletion is a thing I could perhaps do in the future

[lucasvianav]

For me it doesn't, unfortunately. Are you using coq?

[max397574]

no
nvim-cmp
what happens when you don't use a function then?

[max397574]

In the gif you sent

do you use a function there or just the default settings?
@lucasvianav

[lucasvianav]

hey @max397574, sorry for the delay. for that particular gif I don't remember, but here's one with keys = '<Esc>':

[max397574]

so it basically expands some time, some times it deletes a character

imo this can't be an error from better-escape.nvim because it does only feed
and this shouldn't expand or anything

[lucasvianav]

yeah, I'm with you on this, I don't think it's a better-escape.nvim problem. 

it's just a coq_nvim particularity that when escaping with a completion option selected, you have to feed <C-e> before <Esc>, and it'd be nice if better-escape could support it. unfortunately I don't think it's possible, although I don't know exactly what the incompatibility is

regardless, thanks for all the help and the nice plugin :)