Exception 'NSRangeException' when unregistering KVO

[maxep]

Exception 'NSRangeException' when unregistering KVO

[sunnyyoung]

Same problem

[YanSte]

i try the try catch form but not work

[maxep]

Can you give a bit more context ? I cant reproduce on samples. Are you adding the parallax header to a UITableView ? I've made some changes recently that may have introduce this bug.

This does not work ? :

- (void)willMoveToSuperview:(UIView *)newSuperview {
    @try  {
        [self.superview removeObserver:self.parent forKeyPath:NSStringFromSelector(@selector(contentOffset)) context:kMXParallaxHeaderKVOContext];
    } @catch (NSException *exception) {}
}

Can you try this ? :

- (void)willMoveToSuperview:(UIView *)newSuperview {
    if (self.parent) {
        [self.superview removeObserver:self.parent forKeyPath:NSStringFromSelector(@selector(contentOffset)) context:kMXParallaxHeaderKVOContext];
    }
}

- (void)didMoveToSuperview {
    if (self.parent) {
        [self.superview addObserver:self.parent
                         forKeyPath:NSStringFromSelector(@selector(contentOffset))
                            options:NSKeyValueObservingOptionNew
                            context:kMXParallaxHeaderKVOContext];
    }
}

Thanks for the report.

[silvanosouzajunior]

same problem here

[leolelego]

@maxep the try/catch doesn't fix.

The second proposition give this :

[wade0595]

same problem here

leave the view

libc++abi.dylib: terminate_handler unexpectedly threw an exception

[maxep]

Is v0.5.0 has this issue ? are you adding a parallax header to a table view?

[leolelego]

@maxep yes, this is a tableview from me, with static cell. And the app crash when I pop to the view before (UInavigationBar back button).

[silvanosouzajunior]

on the version v0.5.0 is working well

2016-06-20 14:54 GMT-03:00 Léo Derbois [email protected]:

@maxep https://github.com/maxep yes, this is a tableview from me, with
static cell. And the app crash when I pop to the view before
(UInavigationBar back button).

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#28 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ALLOfxCFXh9eaR6A8gmSs5ZOvseOW5ZEks5qNtPFgaJpZM4I11FO
.

[leolelego]

@maxep I just tried like this : pod 'MXParallaxHeader','= 0.5.0' And the crash was not in this release.

[developforapple]

- (void)willMoveToSuperview:(UIView *)newSuperview {
    [self.superview removeObserver:self.parent forKeyPath:NSStringFromSelector(@selector(contentOffset)) context:kMXParallaxHeaderKVOContext];
}

- (void)setTableHeaderViewFrame:(CGRect)frame {

    //Create a table header view that will raise KVO
    MXParallaxView *headerView = [[MXParallaxView alloc] initWithFrame:frame];
    headerView.parent = self;

    [headerView addSubview:self.contentView];
    [(UITableView *)self.scrollView setTableHeaderView:headerView];
    [headerView setNeedsLayout];
}

Conflict between the 2 methods above.
self.contentView's class is MXParallaxView
[headerView addSubview:self.contentView]; self.contentView's superView class also is MXParallaxView.

So [self.superview removeObserver:self.parent forKeyPath:NSStringFromSelector(@selector(contentOffset)) context:kMXParallaxHeaderKVOContext]; make crash.

My Code:

- (void)willMoveToSuperview:(UIView *)newSuperview {
    if ([self.superview isKindOfClass:[UIScrollView class]]) {
        [self.superview removeObserver:self.parent forKeyPath:NSStringFromSelector(@selector(contentOffset)) context:kMXParallaxHeaderKVOContext];
    }
}

- (void)didMoveToSuperview {
    if ([self.superview isKindOfClass:[UIScrollView class]]) {
        [self.superview addObserver:self.parent
                     forKeyPath:NSStringFromSelector(@selector(contentOffset))
                        options:NSKeyValueObservingOptionNew
                        context:kMXParallaxHeaderKVOContext];
    }
} 

[jj-12]

Good fix, but are there any plans of getting this into the next release of MXSegmentedPager?

[maxep]

Fix by #31