Comments (13)
Same problem
from mxparallaxheader.
i try the try catch form but not work
from mxparallaxheader.
Can you give a bit more context ? I cant reproduce on samples. Are you adding the parallax header to a UITableView ? I've made some changes recently that may have introduce this bug.
This does not work ? :
- (void)willMoveToSuperview:(UIView *)newSuperview {
@try {
[self.superview removeObserver:self.parent forKeyPath:NSStringFromSelector(@selector(contentOffset)) context:kMXParallaxHeaderKVOContext];
} @catch (NSException *exception) {}
}
Can you try this ? :
- (void)willMoveToSuperview:(UIView *)newSuperview {
if (self.parent) {
[self.superview removeObserver:self.parent forKeyPath:NSStringFromSelector(@selector(contentOffset)) context:kMXParallaxHeaderKVOContext];
}
}
- (void)didMoveToSuperview {
if (self.parent) {
[self.superview addObserver:self.parent
forKeyPath:NSStringFromSelector(@selector(contentOffset))
options:NSKeyValueObservingOptionNew
context:kMXParallaxHeaderKVOContext];
}
}
Thanks for the report.
from mxparallaxheader.
same problem here
from mxparallaxheader.
@maxep the try/catch doesn't fix.
The second proposition give this :
from mxparallaxheader.
same problem here
leave the view
libc++abi.dylib: terminate_handler unexpectedly threw an exception
from mxparallaxheader.
Is v0.5.0 has this issue ? are you adding a parallax header to a table view?
from mxparallaxheader.
@maxep yes, this is a tableview from me, with static cell. And the app crash when I pop to the view before (UInavigationBar back button).
from mxparallaxheader.
on the version v0.5.0 is working well
2016-06-20 14:54 GMT-03:00 Léo Derbois [email protected]:
@maxep https://github.com/maxep yes, this is a tableview from me, with
static cell. And the app crash when I pop to the view before
(UInavigationBar back button).—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#28 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ALLOfxCFXh9eaR6A8gmSs5ZOvseOW5ZEks5qNtPFgaJpZM4I11FO
.
from mxparallaxheader.
@maxep I just tried like this : pod 'MXParallaxHeader','= 0.5.0'
And the crash was not in this release.
from mxparallaxheader.
- (void)willMoveToSuperview:(UIView *)newSuperview {
[self.superview removeObserver:self.parent forKeyPath:NSStringFromSelector(@selector(contentOffset)) context:kMXParallaxHeaderKVOContext];
}
- (void)setTableHeaderViewFrame:(CGRect)frame {
//Create a table header view that will raise KVO
MXParallaxView *headerView = [[MXParallaxView alloc] initWithFrame:frame];
headerView.parent = self;
[headerView addSubview:self.contentView];
[(UITableView *)self.scrollView setTableHeaderView:headerView];
[headerView setNeedsLayout];
}
Conflict between the 2 methods above.
self.contentView's class is MXParallaxView
[headerView addSubview:self.contentView]; self.contentView's superView class also is MXParallaxView.
So [self.superview removeObserver:self.parent forKeyPath:NSStringFromSelector(@selector(contentOffset)) context:kMXParallaxHeaderKVOContext]; make crash.
My Code:
- (void)willMoveToSuperview:(UIView *)newSuperview {
if ([self.superview isKindOfClass:[UIScrollView class]]) {
[self.superview removeObserver:self.parent forKeyPath:NSStringFromSelector(@selector(contentOffset)) context:kMXParallaxHeaderKVOContext];
}
}
- (void)didMoveToSuperview {
if ([self.superview isKindOfClass:[UIScrollView class]]) {
[self.superview addObserver:self.parent
forKeyPath:NSStringFromSelector(@selector(contentOffset))
options:NSKeyValueObservingOptionNew
context:kMXParallaxHeaderKVOContext];
}
}
from mxparallaxheader.
Good fix, but are there any plans of getting this into the next release of MXSegmentedPager?
from mxparallaxheader.
Fix by #31
from mxparallaxheader.
Related Issues (20)
- Implementation interferes with navbar customization HOT 1
- Items duplicates when added second time HOT 2
- maximumHeight added would be better HOT 1
- MXScrollView cancelled child parallaxHeader-UIScrollView touches HOT 1
- Apple will stop accepting submissions of apps that use UIWebView APIs HOT 2
- How can I set header view height & minimum height with programmatically HOT 3
- I am getting progress value greater than 1.0 initially. HOT 1
- MXScrollView crashes app HOT 21
- parallaxHeader.view not filling superview. HOT 1
- Weird width on MXParallaxHeader 1.1.0 HOT 13
- MXParallaxHeader Scroll issue inside UITableviewHeader HOT 1
- Swift Package Manager support HOT 1
- Keyboard appearance HOT 3
- Animating header height change HOT 1
- The bottom of view in Scrollview is not fully displayed. HOT 2
- Empty space at the bottom of MXScrollViewController HOT 1
- SwiftPackage manager issue HOT 1
- This project is no longer maintained HOT 4
- collectionView.parallaxHeader is nil HOT 1
- Alternative Library HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mxparallaxheader.