Comments (4)
I don't see any issue here. You can define your own default range and utilize it for both the CalendarDialog and your wrapper composable function. If the standard range needs to remain the same, you can easily copy and paste it those constants, allowing you thus easily to change the range if desired. I will keep the constant files and the respective constants internal.
Why would you define the state inside your wrapper function instead of passing it along?
from sheets-compose-dialogs.
Alright, I see. For now I used the approach you suggested, just thought you would consider providing sensible defaults for people to use, however user-defined-defaults work too
I'm making these helper functions for the dialogs because I want to streamline the process of composing and showing the dialog. I've noticed that all of the usecases I've encountered involve declaring the state and immediately calling the Dialog composable, so I've merged those operations together. I'm passing the state as a return value of the function and using it later in the parent composable.
P.S. Github is experiencing serious issues :D
from sheets-compose-dialogs.
Alright, I see. For now I used the approach you suggested, just thought you would consider providing sensible defaults for people to use, however user-defined-defaults work too
I'm making these helper functions for the dialogs because I want to streamline the process of composing and showing the dialog. I've noticed that all of the usecases I've encountered involve declaring the state and immediately calling the Dialog composable, so I've merged those operations together. I'm passing the state as a return value of the function and using it later in the parent composable.
from sheets-compose-dialogs.
Alright, I see. For now I used the approach you suggested, just thought you would consider providing sensible defaults for people to use, however user-defined-defaults work too
I'm making these helper functions for the dialogs because I want to streamline the process of composing and showing the dialog. I've noticed that all of the usecases I've encountered involve declaring the state and immediately calling the Dialog composable, so I've merged those operations together. I'm passing the state as a return value of the function and using it later in the parent composable.
from sheets-compose-dialogs.
Related Issues (20)
- [Feature] Provide withButtonView across all views/dialogs HOT 5
- [Crash] DateTime dialog adds an extra month and day to the initial value HOT 6
- [Feature] Datetime selection dialog is confusing to users HOT 2
- How to change color text and button in ClockDialog? HOT 1
- Allow OptionSheet icons to be in colour HOT 6
- (DateTime) "getLocalizedPattern" is incorrect for Chinese locale HOT 1
- How do I change the text used in calendar HOT 8
- [Feature] Provide Bottom Sheets HOT 2
- [Question] Min version SDK. HOT 5
- [Question] Is it possible to setup a listener for date changes? HOT 3
- How to set color of dialog(dark mode)? HOT 1
- [Feature] Allow setting minimum and maximum date/times for DateTimeDialog HOT 3
- [Bug] Settings "12:00 AM" on the time picker resets the time to 12:00 PM instead HOT 8
- How can I get the selection value of AM or PM to put it in a string? HOT 1
- Support for Compose Multiplatform HOT 1
- Feature: Numeric input HOT 1
- Month text font is too large HOT 1
- Conflict between sheets-compose-dialogs and sheets HOT 4
- Set default selection date. For ex- age restricion for 18 year+
- Language of calendar don't change when changing app language HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sheets-compose-dialogs.