Giter Site home page Giter Site logo

Comments (4)

oschwald avatar oschwald commented on May 27, 2024

This is part of the API and is unlikely to be changed before a new major release, which may never happen. As discussed in #12, if you are getting many of these exceptions, you likely have an integration issue.

That said, we might consider a PR for corresponding Try... methods in the spirit of TryParse.

from geoip2-dotnet.

manigandham avatar manigandham commented on May 27, 2024

Agree with this, exceptions shouldn't be used for flow control.

There are several reasons why the IP might not be valid and if there's no information then it's just a null or lack-of-info response. Even maxmind states that not every IP is included in the database which means there are valid IPs that still throw an error which doesn't make sense.

I'll submit a PR for this.

from geoip2-dotnet.

oschwald avatar oschwald commented on May 27, 2024

Closed by #50.

from geoip2-dotnet.

niemyjski avatar niemyjski commented on May 27, 2024

Thank you!

from geoip2-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.