Giter Site home page Giter Site logo

Comments (5)

oschwald avatar oschwald commented on May 27, 2024

There are many different options to cache the reader object between web requests. Setting up the reader object is expensive and it should not be done each request.

As for opening the reader many, many times as you appear to be doing, you likely would not have the problem when using the memory mode. The error you allude to appears to be a limitation of how memory mapped files are implemented in Windows.

from geoip2-dotnet.

corradin avatar corradin commented on May 27, 2024

I could look into caching thanks for that :). Changing the memory mode will cause memory to go sky high, since after each request memory is increased. I assume the Maxmind DB is loaded into the LOH (Large Object Heap) and .NET has some vulnerabilities in cleaning up the LOH.

from geoip2-dotnet.

oschwald avatar oschwald commented on May 27, 2024

Yeah, at the very least, using memory mode would cause some serious pressure on the garbage collector. Using one of the caching options is the best solution.

from geoip2-dotnet.

manigandham avatar manigandham commented on May 27, 2024

@SP0NG

HTTP is stateless so any web app servicing these requests will need to maintain it's own state, but that being said there's no reason why you can't share services across requests. This geolocation database is just as stateless as your app.

Most services and modules used by asp.net are also implemented as single instances that live for the life of the appdomain so this is an extremely common pattern. You can just use a global static variable holding the database reader that's initialized in the application startup (and disposed in the app shutdown).

from geoip2-dotnet.

oschwald avatar oschwald commented on May 27, 2024

Closing as using a new reader for every request is not recommended. This particular error appears to be an artifact of memory mapping on Windows. If you must create a new reader for every request, it is recommended that you don't use the memory mapping mode.

from geoip2-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.