Comments (9)
@maxmx and @kane-c: any thoughts here?
from bootstrap-stylus.
This isn't like in sass where the root directory would have been added to the path. Unless I'm mistaken I think all the imports in the index.styl are relative no?
from bootstrap-stylus.
I believe that to be partially incorrect.
Assume the following example path:
somePath/mixins.styl
somePath
is included or set as a "paths" value via the JS API (https://learnboost.github.io/stylus/docs/js.html#includepath). When bootstrap-stylus
index.styl
imports mixins
, it would instead import somePath/mixins.styl
.
If somePath
directory was not included or set as a "paths" value then the mixins.styl relative to index.styl would load.
from bootstrap-stylus.
Right, makes sense.
You can submit a PR, I'll bump the major version since that kind of change would break all current usage of the library.
from bootstrap-stylus.
@maxmx I've already submitted a PR. :D #106
from bootstrap-stylus.
@maxmx Anything I can do to move this along?
from bootstrap-stylus.
Done, just had to test it locally first.
from bootstrap-stylus.
Thank for the PR!
from bootstrap-stylus.
@maxmx no no, thank you!
from bootstrap-stylus.
Related Issues (20)
- @require mixins in modules for better dependency management HOT 2
- @extend .clearfix in mixins HOT 3
- Invalid import path in index.styl HOT 10
- Block-grid for Bootstrap HOT 5
- Failed to locate @import file bootstrap/variables.styl HOT 3
- Why imported paths have "bootstrap" folder? HOT 4
- Import font files HOT 1
- navbar build fails HOT 5
- Tag v3.3.6 ?
- index.styl suppose under root? HOT 14
- Stylus bootstrap loaded but not compiled with Webpack HOT 18
- How would i go about adding a XL grid breakpoint with this? HOT 2
- Is the relative path in `index.styl` wrong? HOT 3
- Make it possible to deploy to Webjars HOT 1
- Question: which files just for the Bootstrap grid? HOT 3
- Error with Webpack Can't resolve '../fonts/glyphicons HOT 7
- Webpack's CSS Module and PostCSS loaders underisbly applied on Bootstrap as well
- Index.sty failed to locate imports HOT 1
- bootstrap 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap-stylus.