Giter Site home page Giter Site logo

Comments (8)

nykoo avatar nykoo commented on July 3, 2024 1

Thank you very much for your answer :)
Your tool is great, even for a very code noob as i am.
Thank you

from videodownloader.

nykoo avatar nykoo commented on July 3, 2024 1

will try, thank you

from videodownloader.

mayeaux avatar mayeaux commented on July 3, 2024

My pleasure hopefully you find it useful.

Currently it will just download the highest quality audio and video available, I will probably end up adding functionality whereby you can pass custom flags and then your functionality should be possible.

from videodownloader.

mayeaux avatar mayeaux commented on July 3, 2024

Awesome to hear. Are you on Windows?

Also if you go here:
https://github.com/mayeaux/videodownloader/blob/master/renderer.js#L48

You can pass different flags to youtube-dl and customize the arguments passed. Read up on how youtube-dl works and then you can use that to download custom resolutions

from videodownloader.

nykoo avatar nykoo commented on July 3, 2024

Yes i'm on windows

i found the arguments but don't know how to insert it:
-f "best[height=720]
(Where idi i insret it ? did i remove the // in front of line ? )
anyway not a real problem, downloaded in max resolution and then re-convert it ;)

Thank you again for this tool and for your answers (and sorry for my bad english)

from videodownloader.

mayeaux avatar mayeaux commented on July 3, 2024
 // select download as audio or video
  if(downloadAsAudio){
   ...
  }  else {

     arguments.push('-f');
     arguments.push('best[height=720]')
  }

No problem, add the part I just added in the else {} block and it should work! And your English is fine, happy to help and happy to hear it's working well on Windows :)

from videodownloader.

nykoo avatar nykoo commented on July 3, 2024

Thank you for your so quick answer :)
But it don't work. i certainly did something wrong.
i insert the code in the else {} block of the renderer.js part but then i have an error:

renderer.js:165 stderr: ERROR: requested format not available

renderer.js:165 stderr: Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmphnjfkuku\build\youtube_dl\YoutubeDL.py", line 807, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmphnjfkuku\build\youtube_dl\YoutubeDL.py", line 861, in process_ie_result
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmphnjfkuku\build\youtube_dl\YoutubeDL.py", line 1634, in process_video_result
youtube_dl.utils.ExtractorError: requested format not available

renderer.js:182 child process exited with code 1

The video is playable in 720 via youtube.

Anyway really not a problem i convert it to the size i needed and this is perfect.

Again thank you very much for your coding skills and you kindness.

from videodownloader.

mayeaux avatar mayeaux commented on July 3, 2024

Try to run youtube-dl -F yoururl.com to get the available formats. If you get youtube-dl working from the command line you should be able to test things manually before you plug it into videodownloader

from videodownloader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.