calling an async method in Request handler crashes the bus

[mayuanyang]

calling an async method in Request handler crashes the bus

[mayuanyang]

Hi!
Thanks for getting in touch, i am working on this issue now and will keep you updated
Regards
Eddy

[mayuanyang]

Hi

Just wrote a test case and did not manage to reproduce the problem, can you please advice which instance is actually null?

Here is my test case

Mediator.Net/src/Mediator.Net.Test/TestRequestHandlers/TestAsyncRequestHandler.cs

Line 21 in 7c348ef

var response =

The handler

Mediator.Net/src/Mediator.Net.TestUtil/Handlers/RequestHandlers/AsyncRequestHandler.cs

Line 14 in 7c348ef

await Task.Delay(100, cancellationToken);

and the result is in here
https://ci.appveyor.com/project/mayuanyang/mediator-net

[SuheylZ]

sorry for a delayed response. Let me have a look at the test case you mentioned.

[SuheylZ]

I need to share some private code with you for the same. Queries if made async it just errors out that Response is null.

[mayuanyang]

Sure thing
, how would you like to send?

[SuheylZ]

can't do it on github? how about skype? i don't know if it's okay to share it here. or any other way that you think would work

[mayuanyang]

Email would work for me [email protected]

[basbros]

Same problem for me.

I share a solution (net Core 3.0) to reproduce the problem
Mediator.zip

The problem seems to be in the RequestPipe.cs, ConnectToHandler(), line 64
task.GetType().GetTypeInfo().GetDeclaredProperty("Result")

it returns null

[basbros]

Sorry, it seems already fixed with 3.0.0 dev20

[SuheylZ]

Is there any update for the async handlers for queries?

[mayuanyang]

Hi @Mercedex
Sorry for being late, was extremely busy, however i managed to get some time and write some tests, the tests seems working fine for me, you might interest on the following files

• The test https://github.com/mayuanyang/Mediator.Net/blob/inheritanceTest/src/Mediator.Net.Test/TestInheritance/TestInheritanceSpec.cs

• The handlers being used for the tests
  https://github.com/mayuanyang/Mediator.Net/blob/inheritanceTest/src/Mediator.Net.TestUtil/Handlers/CommandHandlers/InheritanceBaseCommandHandler.cs
  https://github.com/mayuanyang/Mediator.Net/blob/inheritanceTest/src/Mediator.Net.TestUtil/Handlers/RequestHandlers/InheritanceBaseRequestHandler.cs

Can you please have a look and check if i missed anything, also please note that the tests were written against the 3.0.0-dev in case if you are using 2.x.x

Regards
Eddy

[SuheylZ]

Sure, I would do that.

Busy working on another large scale system and planning on using your implementation for that also.

Is it possible that I can have submit fixes, if any to you and you can add them after verifying?

[mayuanyang]

For sure, you are very welcome to do so :)