Comments (5)
If Encompass is using a wallet type (be it Trezor, or a special multisig, or whatever) that does not support the full array of coins, those chains should not be available.
It is presumable a user could do as suggested above, but it's noted that the user's coin wouldn't be lost - it would be recoverable with custom firmware, or any wallet supporting the seed/root key derivation used in the Trezor.
Also: there's no need to ask the user (who likely has no idea) if they have custom firmware - better to ask a device. But the firmware could /change/ at any point - there's no guarantee that coins supported today by X hardware will continue to be supported tomorrow.
from encompass.
What Encompass currently does is:
- Ask the trezor device for a list of the currencies it supports
- Check if the active chain's name is in that list
- If the active chain isn't in the list, warn the user and force watching-only mode.
So it will generate keys for whatever currencies that Encompass and your Trezor firmware support. However, I see that forcing watching-only mode might not be enough. Maybe Encompass should not allow the wallet to be used in this case?
from encompass.
I would personally prefer the addresses for a currency unsupported by the firmware, not be created.
from encompass.
@ELM4Ever I'm not sure that that's very easily achieved with the current code
@Kefkius maybe there's a way we can have Encompass simply not display chains not supported by the firmware? (or make it so that those chains are not on the list of chains to select)
Trezor is not terribly unique, funds can be recovered with any of several different apps, so I do know that even if the user were to see an MZC address, and send funds, they'd be recoverable.
from encompass.
@guruvan there is a way to omit unsupported chains in the "Change Currency" dialog. However, this alone doesn't address the possible situation in which a wallet is opened while the active chain is unsupported by the device's firmware.
I'm currently exploring a solution that strikes a balance between "protect the user" and "the user knows best." Possibly, the solution would be to add a warning to the status bar when a trezor wallet is using an unsupported active chain.
from encompass.
Related Issues (20)
- Requests Root to Install, Will Not Install on Root HOT 1
- Cannot switch chains from GUI when daemon is running HOT 1
- Latest Develop branch 20150613: can't change currency from GUI on a Trezor HOT 1
- setchain with daemon does not switch electrum-server HOT 3
- stuck transaction HOT 10
- sending DASH fails HOT 2
- OSX El Capitan prevents command line install HOT 2
- Trezor not working on new OSX 0.6.0RC1 binary (pkg) HOT 5
- Validating Integrity and Authenticity of Encompass-0.5.0-OSX_Installer.pkg HOT 2
- Updates? HOT 7
- Multisignature Derivation compatibility with Electrum
- 0.5.0 importprivkey issue HOT 1
- 0.5.0 Windows dash payment issue HOT 11
- 0.5.0 Windows dash payment issue 2 HOT 2
- SSL certificates
- multisig with hardware wallets HOT 6
- namecoin and coloredcoin HOT 2
- Automated export of transaction ID [$200] HOT 24
- licensing infos for dependency ltc_scrypt HOT 11
- Command line not accepted when on Trezor wallet HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from encompass.