Giter Site home page Giter Site logo

Comments (3)

mchehab avatar mchehab commented on June 3, 2024

Well, make distcheck was not set to work, as it needs this on Makefile.am:

AM_DISTCHECK_CONFIGURE_FLAGS = --enable-all

Even so, it actually tries to install rasdaemon at the build machine, which is something I don't do, as I prefer to generate a rpm tarball and install from it (I'm running Fedora).

What it was actually missing seems to be a git workflow that would be running make dist-bz2 for targets, placing the distro tarball at the github repository.

from rasdaemon.

mchehab avatar mchehab commented on June 3, 2024

Added a workflow to place the content of "make dist-bzip2" as an artifact. It should work starting on v0.7.0:

https://github.com/mchehab/rasdaemon/releases/download/v0.7.0/rasdaemon-0.7.0.tar.bz2

from rasdaemon.

kepstin avatar kepstin commented on June 3, 2024

The 'make distcheck' doesn't actually install the package to the system - but it does run 'make install' with DESTDIR set to a temporary directory (and cleans up the result afterwards).

When using autotools build system, it's usually best to use make distcheck (when possible) instead of one of the make dist targets since it does a full build and install in a way that verifies that out of tree builds, DESTDIR installs, and clean targets all work correctly - things that are sometimes missed in a local development environment.

The main downside is of course that a full build and install can be pretty slow. I'd totally understand avoiding it in a CI situation - doing only the dist step would make sense to save resources especially if you're already doing build/install tests elsewhere :)

from rasdaemon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.