False negative on hatch run test inside container environment

[kaestro]

False negative on hatch run test inside container environment

[antonymilne]

Just for more context, we use chromedriver-autoinstaller to install chromedriver for running integration tests locally, because it's fiddly to install manually. This should work so long as you have chrome installed.

As @l0uden said above though, chromedriver is only needed for the integration tests, and 99% of the time all you need to run locally is hatch run test-unit and not the full test suite that includes integration tests. So if it's not easy to run integration tests locally they're fine to ignore.

[l0uden]

Hi @kaestro!

Thanks for spotting this!

If you want to run integration tests (which is a part of hatch run tests command) you should install Chrome manually. Given the difficulties with creating a process to automatically install Chrome on the range of operating systems that users might be using, it would make most sense to add this step to manually install Chrome to the contribution documentation here. Or you can just raise a ticket for the docs change if you have limited time to contribute.

(You can run also unit tests separately using hatch run test-unit command - and for the docs change all you need is to check the linting by using hatch run lint)

[kaestro]

I think my I idea was short-sighted after reading your description.

And like you've just said, adding that to the documentation will perfectly make sense!

Thank you :)