2 errors in ReplaceNumber

[mdaliyan]

2 errors in ReplaceNumber

[mdaliyan]

I don't have a PHP environment setup on my device to test these but I think you're right. Could you make a PR for these?

[Anisi]

I think it isn't related to PHP version or specific environment configuration, I resolved first problem by pull request and the second problem is a necessary feature.
By the way:

1. Install Laravel 7.*
2. Install package
3. Follow package configuration steps as described in the doc
4. Use trait like this:

...

    private $mustHaveEnglishNumbers = ['firevehicles.*''];
    public function rules()
    {
        return [
            'firevehicles' => 'required|array',
            'firevehicles.*' => 'integer',
        ];
    }

...

Following Laravel validation convention, It is desirable that firevehicles.* be valid.

[Anisi]

I'm still waiting for your opinion about firevehicles.* feature

[mdaliyan]

I think it's a must. I'm miles away from PHP these days, so I contacted my ex-coworkers if any of them are interested in working on it or not. Still no response. I'll be glad to hear if you have any solution for this already.

[mdaliyan]

Ok, I just found a new volunteer to fix this. He will join this conversation.