incorrect dinf flow accumulation in test_grid.py

[mdbartos]

incorrect dinf flow accumulation in test_grid.py

[itati01]

Another issue: some extra cells appear in top row. I found them while evaluating the flow accumulation with efficiency (#73).

np.where(grid.dinf_acc_eff<grid.dinf_acc)`
Out[92]: (array([0, 0, 3, 4], dtype=int64), array([ 4, 5, 131, 132], dtype=int64))

The cells (0,4) and (0,5) are wrong. Without efficiency:

grid.dinf_acc[0,4]
Out[94]: 3115.7132796632914
grid.dinf_acc[0,5]
Out[95]: 8288.15039690737

Et voilà, they receive the outflow of the darkish cell mentioned above

grid.dinf_acc[0,5] + grid.dinf_acc[0,4] - grid.dinf_acc.max()
Out[101]: 1.000000000001819

Which is where I put the retention cell (which matches the observed differences for cells (4,131) and (5,132).

np.where(grid.dinf_acc==grid.dinf_acc.max())
Out[106]: (array([3], dtype=int64), array([131], dtype=int64))

The values for (0,5) and (4,132) (the reddish cell above) are identical:

grid.dinf_acc[0,5] - grid.dinf_acc[4,132]
Out[112]: 0.0

[mdbartos]

Greetings, try updating to pysheds v0.3 and reopen if the issue persists.