Recursive function d8_catchment_search causes Python to crash

[mdbartos]

Recursive function d8_catchment_search causes Python to crash

[mdbartos]

Greetings,

It's been several years since I wrote the original implementation, so I think refactoring would certainly be a good idea. Namely, the current implementation uses a list to store visited cells, which may not be ideal memory-wise. It would probably be better to just use a boolean array. I'm not sure if getting rid of the recursion would necessarily help with memory consumption.

What size DEM are you using?

[DominiqueBrunet]

The original DEM I am using is about 17000x18000 pixels, but the bug occurs even when I crop it to about 1500x1200.

Getting rid of recursion worked for me without memory problem.

[mdbartos]

Greetings,

I'll take a look at this issue soon. It shouldn't be crashing on a DEM of that size though. See this example for instance (5000 x 5000): https://github.com/mdbartos/pysheds/blob/master/examples/no_metadata.ipynb

It may be that you are calling the function on the original data source rather than the clipped 'view' of the data.

[DominiqueBrunet]

The clipped DEM for six different larger watersheds lead to a crash, but other smaller ones worked fine, so I don't think it has to do on how I clipped the data.

I can try to extract and package the data and code that generated the error if you want. How would you like the data?

[mdbartos]

Greetings, this should be fixed in v0.3, as the python catchment function has been reimplemented in numba. Please reopen if the issue persists.