Comments (10)
I'm really sorry for the inconvenience here. I really didn't intend to do anything shitty.
I don't really know of a good way other than the usual semver major version change to let people know about breaking changes. Is there some specific reason you can't continue to use v1?
from ejs.
Yea, we released with >1.0.0 in our packages.json, something we often do because we trust upstream authors not to implementing breaking changes without notifying us of deprecated methods.
Excuse me for being blunt but we're getting annoyed users...
What really needs to happen here is a new version is released by yourself. This new version rolls back the API and notifies users for X months that methods are deprecated (This can be each time they are used).. Your V2 should support methods from V1, but under a deprecated flag, that's pretty much all... Is that doable?
from ejs.
I totally understand the problem with annoyed users, and I've experienced the same problem with a dependency breaking out from under me. (Although in that case, it was major breaking changes at the patch level, which is not at all something you should expect.) In any case, I'm really sorry.
I implemented this as a major version change because semver explicitly permits breaking changes between major versions. You're right that ideally I would have let people know somehow, and some sort of deprecation notice would have been a lot better experience.
Before I pushed any of this I made sure that all the v1 tests pass with the exception of filters. Is that the feature that you're depending on in your project?
from ejs.
From what I see we're not using filters so I wonder if you are lacking test coverage.. Pretty much all of our ejs logic can be seen here: https://github.com/ether/etherpad-lite/blob/develop/src/node/eejs/index.js
from ejs.
Yes, possibly something edge-casey that the tests don't cover. We actually used EtherpadLite heavily early on at Yammer, and employed Peter Martischka there for a while. He's a good guy.
Can I repro the problem by just building or running the project? If not, what are some basic repro steps?
from ejs.
Yea, just building will reproduce the problem :)
from ejs.
Thanks. I'll take a look.
from ejs.
Thanks @mde also sorry for being abrupt!
from ejs.
All right, I've pushed a fix for this in v2.0.6. EtherpadLite's bootstrap code is directly accessing the internals of the EJS lib, using an undocumented internal variable directly. This is clearly not a great idea. (Blind updates between major versions of a supporting lib aren't nearly as heinous, but they're also a recipe for breakage. See http://semver.org/ for what types of changes to expect at different version levels.) I'll be removing this bandaid eventually. Let me know if you need some help figuring out how to clean up that bootstrap code.
from ejs.
RE help, yes please! if you can clean up the hacks we had to put in place (due to adopting so early) then that would be awesome!
from ejs.
Related Issues (20)
- Option to not overwrite unchanged files when using CLI?
- Functions do not return embedded HTML HOT 2
- Add a precompile step HOT 3
- Update jake dependency to avoid [email protected] snyk vulnerability HOT 1
- Fetching Include from a database? HOT 1
- Client True includes are not getting imports recursively HOT 1
- <%-%> auto converting \n in <br> HOT 1
- I just canβt solve the problem with include, I tried different methods, different syntaxes HOT 1
- global scope of variables HOT 1
- Meterian Scan - Security Issue (concat-map version 0.0.1) HOT 4
- Cannot read properties of null if CSS is linked HOT 2
- Is there a way to use ejs on the front-end? HOT 3
- How can we automate dependencies update in project with placeholders? EJS HOT 1
- Eval issue; "data is not defined" HOT 1
- jake aborted - unable to make/build ejs HOT 2
- uglify is not recognized HOT 1
- async option is not true async 3.1.10
- Include partial inside of another partial HOT 2
- How to deply express app with ejs files on netlify.
- SECURITY.md explained HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ejs.