Error: Unknown encoding in Node.js 0.8

[mde]

Error: Unknown encoding in Node.js 0.8

[TimothyGu]

We don't officially support Node.js 0.8, but I would be happy to apply fixes for it if it's not too ugly.

It seems to me that node 0.10 changed the second argument to readFileSync from a string specifying the encoding to an object containing that.

I'll push a fix using readFileSync(file).toString('utf8') using the Buffer.prototype.toString() function that did not change since 0.8. See if that fixes your problem.

[TimothyGu]

See also 4ffd77f and 58e7f75. The latter commit was by me after I saw 4ffd77f.

[dougwilson]

I believe fs.readFileSync(fileName, 'utf8') still works on post Node.js 0.8, so that could be a solution as well (replace the options object with a string).

[dougwilson]

https://github.com/joyent/node/blob/v0.10.24/lib/fs.js#L274-L275

[TimothyGu]

True but I'd rather use documented behavior.

[TimothyGu]

I just tested on:

> console.log(process.versions)
{ http_parser: '1.0',
  node: '0.8.28',
  v8: '3.11.10.26',
  ares: '1.7.5-DEV',
  uv: '0.8',
  zlib: '1.2.3',
  openssl: '1.0.0m' }

Everything seems to work fine with Node.js 0.8. We are still not officially supporting 0.8 though because some of our devDependencies don't support it anymore.

[dougwilson]

Thanks, I appreciate making the change anyway :)

[mde]

@dougwilson Do you need a bugfix release with this change?

[dougwilson]

@mde , no, take your time, I'm in no rush.

[mde]

👍