Issue with sitemap: null

[mdreizin]

Issue with sitemap: null

[github-actions]

🎉 This issue has been resolved in version 1.6.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[holm]

I am seeing the same issue after the update. The plugin documentation explicitly recommends setting sitemap to null for dev/test.

[holm]

Seems to have come from the changes in #441

[iamskok]

@mdreizin Please re-open the issue. The fix wasn't merged in 1.6.8 CI output

semantic-release didn't generate a new version. I think it happened because PR didn't include a commit message with the word fix.

[laurenskling]

yes, #441 breaks the possibility to have sitemap: null as stated in the documentation

[holm]

cc @moonmeister

[moonmeister]

Yup, we just need a null check and some tests probably. I'll do it if I find time.

[mdreizin]

@moonmeister @laurenskling @eDubrovsky I am really sorry, but I don't have a free time to fix that issue. I would appreciate if someone could look at it and fix.

[moonmeister]

@mdreizin or whomever...I'm trying to understand how you're getting an error thrown here. the lines 59-69 of this code should check for this null value and properly fill in the site url from the siteUrl metadata. So if this value is truly null then you must not be setting siteUrl. The whole point of setting the plugin config sitemap value to null is to fallback to that other value...if both are null we can provide a cleaner error but there's nothing we can do. Can you better explain what's happening or what you expect to happen? Links to your gatsby-config.js files could be helpful in fixing this bug. Thanks

[moonmeister]

Just realized those existing if statements aren't null checks, they're checking for existing properties, null or not. I'll look at this again and see what what I can figure out.

[wezter96]

Has this issue been resolved?
I seem to get the same issue.

[moonmeister]

I don't believe so.

[wezter96]

@moonmeister could I just reroll to an older version of the plugin and then this issue wouldn't exist?
or should i change sitemap: null to something else?

[moonmeister]

Sure but you'll have other issues that this update solved. I may have time to check this out soon. Feel free to contribute a fix too.

[laurenskling]

Can we please have a release of the fix? 😅

[mdreizin]

Please check the latest version.

[Dananz]

Please check the latest version.

@mdreizin I don't think that the npm version is synced with the current repo version.

[laurenskling]

The merge isn't released into a release, would that be possible @mdreizin ?

[eDubrovsky]

@mdreizin this fix not merged into the 1.6.8 version. 😿

[CassieSloan]

Updated to most recent version of gatsby-plugin-robots-txt and our builds aren't running bc of the above. Any updates on when this will be fixed?