[BUG] Task not showing as completed and missing reward, although all subtasks are green

[mdziekon]

[BUG] Task not showing as completed and missing reward, although all subtasks are green

[mdziekon]

I was able to confirm this bug. I was able to reproduce it with the provided "steps to reproduce", however only when both users did not have the mentioned task completed yet (when only one of them had this task unfinished, the bug would not occur).

The problem is not limited to the Task 11: Players' unions task only - this will most likely happen in all cases where there are tasks checked for more than one player at a given time.

[mdziekon]

PR #114 with a fix has been merged.

@bblaha can you please fetch the most recent version with this fix and verify that it solves the problem for you?

[bblaha]

Is there any way I can re-check for that specific task? I can definitely say that is does not fix itself after an update, so I guess I would have to check for task completion again?

[mdziekon]

Is there any way I can re-check for that specific task? I can definitely say that is does not fix itself after an update, so I guess I would have to check for task completion again?

The only way to do that would be to manually modify user's data in the database. There's currently no way to perform any re-check in the game's engine itself.

[mdziekon]

I've thought about this once again and tried to provide a graceful migration process allowing server instance owners to automatically fix the locked up tasks for all of the existing users. The migration involves running a one-off script manually in the migration process, and will be introduced in PR #115

@bblaha, could you try to pull this PR locally (branch mdziekon/112/bugged-tasks-fix-scripts) and try to apply it on your instance, to see if it actually fixes the problem "semi-automatically"? You should start by running the migrations, after that the migrator should tell you what to do next. As with every migration, it is recommended to run a full backup of your instance in case if something goes wrong.

[mdziekon]

It's been 5 days now with no answer from the original reporter, so to move on I have to "confirm" resolution myself. All my previous tests with both the patch and the migration / autofix scripts applied showed that it does indeed work and autoheals the instance's DB state.

Therefore, I'm marking this bug as fixed and closed. @bblaha, if you'll ever come back to this and find that the mentioned patches did not fix it for you, I would suggest opening up a new issue with a link back to this one.