Comments (3)
Hi,
regarding the #88. How about changing the line 582 from
if ($resourceCurrentAmount >= $resourceMaxStorage)
to if ($resourceCurrentAmount > $resourceMaxStorage)
?
this way it does not block the resource mysql recalculation when the values are equal.
Worked for me.
from uniengine.
Hi @theGroom66, thanks for your suggestion, really appreciate it!
I haven't touched this bug in a long time, so I'll have to read that code through again and try to validate if your proposal works fine - resource calculation code can be tricky, especially when it comes to stacked updates. I hope I can get this validated in a couple of days.
As an additional question, what did you do to validate this fix on your end? Did you run some extensive tests? What about your testing environment, if you don't mind sharing that info? Did you run it locally, or on some public/semi-public instance where other people than yourself play the game on a regular basis?
from uniengine.
Hi @mdziekon ,
You're welcome. I was just interested in Your project, so I cloned and ran it to give it a try. I've seen some of Your issues and tried to figure one out. The instance is living on my personal server to used only by me. It is a nice reading, the code, must have been a lot of work. Appreciate it man!
from uniengine.
Related Issues (20)
- Refactor Fleet flights list
- [BUG] Allied protecting flights translation error
- Adjust Phalanx mechanism
- [BUG] "Interplanetary strike" option on Planet hover menu does not work
- Bring back basic CI workflow
- [BUG] Returning from `fleet2` to `fleet1` incorrectly assumes Union has been chosen
- Refactor galaxy rendering
- Refactor Phalanx view
- Refactor user settings
- Refactor Overview pages
- [BUG] Chat message rows background is annoying on new messages
- Ares engine lacks randomization of targets HOT 1
- [BUG] Shipyards never stop working HOT 2
- Refactor Info pages
- [Question] Uncharted space HOT 2
- [BUG] generate_sig not working. HOT 4
- [BUG] Signatures do not work in Docker environment
- [BUG] Statistics generator throws a warning in Docker environment
- Responsive Template HOT 1
- [BUG] Time are not displayed to my timezone HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uniengine.