onDisconnect sometimes doesn't fire (on hold)

[me-no-dev]

onDisconnect sometimes doesn't fire (on hold)

[bertmelis]

I'm totally lost:
I changed _close():

int8_t AsyncClient::_close(){
    //ets_printf("X: 0x%08x\n", (uint32_t)this);
    int8_t err = ERR_OK;
    if(_pcb) {
        //log_i("");
        tcp_arg(_pcb, NULL);
        tcp_sent(_pcb, NULL);
        tcp_recv(_pcb, NULL);
        tcp_err(_pcb, NULL);
        tcp_poll(_pcb, NULL, 0);
        _tcp_clear_events(this);
        if(_in_lwip_thread){
            err = tcp_close(_pcb);
        } else {
            err = _tcp_close(_pcb);
        }
        if(err != ERR_OK) {
            err = abort();
        }
        _pcb = NULL;
        if(_discard_cb) {
            log_i("calling onDisconnect");
            _discard_cb(_discard_cb_arg, this);
        }
    }
    return err;
}

Now the output is

[W][AsyncTCP.cpp:631] _poll(): rx timeout 4
[I][AsyncTCP.cpp:543] _close(): calling onDisconnect

but onDisconnect is not called!

When it is preceeded by an ack timeout, it does work:

[W][AsyncTCP.cpp:624] _poll(): ack timeout 4
[W][AsyncTCP.cpp:631] _poll(): rx timeout 4
[I][AsyncTCP.cpp:543] _close(): calling onDisconnect
[I][MqttConnect.cpp:123] _onMqttDisconnected(): MQTT disconnected

[bertmelis]

Turns out, AsyncMqttClient only calls onDisconnect when it receives a disconnect confirmation from the broker and not when it is just disconnected by lwip.

(apologies for the non-issue)