Giter Site home page Giter Site logo

Comments (5)

0x24a537r9 avatar 0x24a537r9 commented on July 20, 2024

Tabs vs. spaces is always a contentious issue, so I won't argue that either is intrinsically better, but I tend to agree that it should be an option since sed-ing is prone to be forgotten and the link the .editorconfig file references for its JS style (https://github.com/felixge/node-style-guide#2-spaces-for-indention) actually specifically recommends using 2 spaces for indentation (meaning the .editorconfig is in fact internally inconsistent).

Given that both node.js itself and consequently a majority of node.js and Express code uses 2-space indentation as a standard, I would argue that 2-space indentation should be the default for no other reason than simple consistency. Lacking that (perhaps reasonably to maintain the unfortunate inconsistency of the core meanjs codebase), I would at least hope for a means of configuring the meanjs generators to perform the sed automatically.

To clarify the specific needs, what would such a PR entail? I'm unfamiliar with the innards of Yeoman, and thus unaware whether the kind of generator-module-level configuration needed to record whether to use tabs/spaces in future yo's is even supported.

from generator-meanjs.

lirantal avatar lirantal commented on July 20, 2024

Hey guys,

We have indeed pushed this change in and on the upcoming 0.4.0 release of MEAN.JS we will be using 2 spaces. As of now, we re not planning to release any updates to the generator repository (sorry).

It's coming.. really really soon, as in this week! Stay tuned.

from generator-meanjs.

xiaoquqi avatar xiaoquqi commented on July 20, 2024

Sound great to me. Thanks.

from generator-meanjs.

0x24a537r9 avatar 0x24a537r9 commented on July 20, 2024

Woohoo! One more reason to love MEAN.JS.

from generator-meanjs.

lirantal avatar lirantal commented on July 20, 2024

@xiaoquqi @0x24a537r9 - 0.4.0 released now and merged into master branch.
You can also find the 0.4.0 tag here: https://github.com/meanjs/mean/releases/tag/v0.4.0

from generator-meanjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.