Comments (5)
Tabs vs. spaces is always a contentious issue, so I won't argue that either is intrinsically better, but I tend to agree that it should be an option since sed-ing is prone to be forgotten and the link the .editorconfig file references for its JS style (https://github.com/felixge/node-style-guide#2-spaces-for-indention) actually specifically recommends using 2 spaces for indentation (meaning the .editorconfig is in fact internally inconsistent).
Given that both node.js itself and consequently a majority of node.js and Express code uses 2-space indentation as a standard, I would argue that 2-space indentation should be the default for no other reason than simple consistency. Lacking that (perhaps reasonably to maintain the unfortunate inconsistency of the core meanjs codebase), I would at least hope for a means of configuring the meanjs generators to perform the sed automatically.
To clarify the specific needs, what would such a PR entail? I'm unfamiliar with the innards of Yeoman, and thus unaware whether the kind of generator-module-level configuration needed to record whether to use tabs/spaces in future yo's is even supported.
from generator-meanjs.
Hey guys,
We have indeed pushed this change in and on the upcoming 0.4.0 release of MEAN.JS we will be using 2 spaces. As of now, we re not planning to release any updates to the generator repository (sorry).
It's coming.. really really soon, as in this week! Stay tuned.
from generator-meanjs.
Sound great to me. Thanks.
from generator-meanjs.
Woohoo! One more reason to love MEAN.JS.
from generator-meanjs.
@xiaoquqi @0x24a537r9 - 0.4.0 released now and merged into master branch.
You can also find the 0.4.0 tag here: https://github.com/meanjs/mean/releases/tag/v0.4.0
from generator-meanjs.
Related Issues (20)
- CRUD modules HOT 1
- Generate client modules only? HOT 1
- angular-modules working locally not working on heroku HOT 4
- CRUD Module Server Test Templates over specify the resolution method. HOT 2
- Logout should not use GET HOT 2
- yo meanjs:crud-module <module-name> - create fails HOT 8
- why dont i get the option for 0.5.0 when running "yo meanjs" ? HOT 1
- Genreator yo meanjs not working HOT 1
- .git folder
- Out of the box install doesn't work with Node v7.2.1 HOT 4
- travis.yml errors on build
- Not creating angular files in public folder
- Problem adding new menu to the topbar
- node-pre-gyp install --fallback-to-build error HOT 1
- Mean Generator appends the current directory in the path
- A valid Gruntfile could not be found. Please see the getting started guide for more information on how to configure grunt: http://gruntjs.com/getting-started Fatal error: Unable to find Gruntfile. HOT 2
- Yo generator CRUD module routing
- Couldn't install Mean.Js app using Yo generator HOT 2
- Hi @prabhatmishra33 did you solve the problem? I'm having the same issue...
- The term 'rm-rf' is not recognized as the name of a cmdlet
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from generator-meanjs.