MouseClick problem

[melonjs]

MouseClick problem

[norb42]

finally those test instead of collision don't change anything but I had too much JS error with collision without even be able to reproduce them each time

so I have made some change to manage up and down function (to implement drag & drop) and update the sample4 : http://norb.zxq.net/melonJS/sample4/

But I still don't understand why I have this 10 pixel difference inside the mouse event

If you want to take a look at the modif : https://github.com/norb42/melonJS/commits/master

Version 9.3 on FF

hmm weird...

what about something missing/wrong in the translateMouseCoords() function when returning the x/y pos inside the canvas ? Looks like some offset missing (distance between the page and the canvas?)... Did you try any other example where your canvas is located on the top left part of the page to see if the problem is there too ?

I was checking the Safari Developer Library and noticed they are using another method to get the mouse position :
https://developer.apple.com/library/safari/#documentation/AudioVideo/Conceptual/HTML-canvas-guide/AddingMouseandTouchControlstoCanvas/AddingMouseandTouchControlstoCanvas.html

as they using the pagex/pagey properties, I wonder it this one is maybe more accurate,and maybe makes more sense with modern browser.

would you give it a try ?

Actually, even if it does not change anything, I think I will update my code to use that. won't maybe make any real difference for mouse event (despite maybe the current bug), but it will make it a little easier to manage touch event (as less variable are then different)

http://stackoverflow.com/questions/5085689/tracking-mouse-position-in-canvas

Is your canvas by any chance 10px far from the page border ? seems it's the issue to me ...

And actually it is, based on the below link, i update the translateMouseCoord function like this :

    /* ---

         translate Mouse Coordinates

        ---                             */
    function translateMouseCoords(x, y) {
        var obj = me.video.getScreenCanvas();
        var curleft = 0;
        var curtop = 0;

        do {
            curleft += obj.offsetLeft;
            curtop += obj.offsetTop;
        } while( obj = obj.offsetParent ) 

        return new me.Vector2d(x - curleft,
                               y - curtop);
    };

and also now calls it using pageX,pageY
translateMouseCoords(e.pageX, e.pageY)

and... it works !

[norb42]

perfect !!!! :)

messed up with the commits, but I used the above method as well and "cached" the canvas offset within the page.
I don't know if you plan any pull request, else on my side I plan to finish some first implementation based on yours for this weekend, and maybe will also add touch event (once mouse event are fully done, adding some touch event is quite easy)

[norb42]

nothing planed, I'm actually test to make mini game to find out what is missing in MelonJS, but you will also implement the enter and leave event ?

so here it is :

https://github.com/obiot/melonJS/issues/6