Comments (2)
@aaronsteers I was thinking of making the buffer from #26 configurable in a future iteration by adding another config key for something like buffer_s
but your proposed solution sounds like it would achieve it without having a new key and it would also be a good implementation reference for meltano/sdk#922.
One thing I'm considering is that as the tap developer I think I still want to force a buffer like this to avoid users shooting themselves in the foot. It took a fair amount of iteration and monitoring for me to figure out this was the problem, and I still need to see it work in prod to know for sure, so I'd want to make that an implementation detail of this tap. If users provide an end_date newer than 5 mins then I'd still automatically force the 5 mins buffer for safety. If we find cloudwatch docs explaining it with a more accurate SLA (likely in the seconds range vs mins) then I can shorten the hard coded buffer but I wouldnt want to give the user unsafe configuration options.
from tap-cloudwatch.
One thing I'm considering is that as the tap developer I think I still want to force a buffer like this to avoid users shooting themselves in the foot.
Love it! Yes 👍
If users provide an end_date newer than 5 mins then I'd still automatically force the 5 mins buffer for safety. If we find cloudwatch docs explaining it with a more accurate SLA (likely in the seconds range vs mins) then I can shorten the hard coded buffer but I wouldnt want to give the user unsafe configuration options.
That's really smart. I hadn't really thought that far, but yes, I totally agree an enforced minimum offset sounds like the right thing to do.
from tap-cloudwatch.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tap-cloudwatch.