Giter Site home page Giter Site logo

nsvg__parseRotate Bug about nanosvg HOT 2 CLOSED

memononen avatar memononen commented on August 26, 2024
nsvg__parseRotate Bug

from nanosvg.

Comments (2)

bryanmcconkey avatar bryanmcconkey commented on August 26, 2024

also line 1317
nsvg__xformSetTranslation(xform, args[1], args[2]);

I suspect the 'xform' parameter is meant to be 't', as that 'xform' is not used and memcpy-ed into a couple lines later.

from nanosvg.

memononen avatar memononen commented on August 26, 2024

Thanks for the fix! The reason for memcpy on those functions is probably that I wrote nsvg__parseMatrix() first, which needs temp storage because of the early out, and just stuck with the pattern. They could safely modify xfrom instead.

from nanosvg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.