Comments (4)
+1 for type hints.
In a similar vein, I suggest that the library adopt the leading underscore convention for private or protected attributes in specific classes. For instance, attributes like headers.headers
or message.message
might be more intuitively named headers._headers
or message._message
. While it's ideal for everyone to thoroughly read the documentation before using the library, in practice, many developers experiment first and may be misled by their IDE's intellisense. By using a naming convention that more clearly indicates the attribute's intended visibility or scope, we can make the API more intuitive and reduce potential confusion.
I commented here instead of opening an issue as it felt in line with the discussion
from memphis.py.
Hi @msiwik-epruf, thanks for the willing jump in and start contribute this is awesome.
Regarding the first point - in case no schema is attached to the station only bytearray is allowed, but for the different schema data formats another types allowed. For example if you have a station with JSON schema attached you can send dict.
Regarding the second issue, this is indeed an issue and we will be glad. to see you fixing it and open a PR.
Regarding other things we would like to see on the Python side, are you familiar with Celery?
from memphis.py.
@idanasulinmemphis Hey,
Regarding the first point - in case no schema is attached to the station only bytearray is allowed, but for the different schema data formats another types allowed. For example if you have a station with JSON schema attached you can send dict.
Maybe here we can have some Union type to show which types are allowed and etc.
Regarding the second issue, this is indeed an issue and we will be glad. to see you fixing it and open a PR.
Ok
Regarding other things we would like to see on the Python side, are you familiar with Celery?
Yeah, but it depends on use case. Currently we use celery with multiple workers/ques for lot's of tasks
from memphis.py.
@msiwik-epruf so we actually want Memphis to be supported for the Celery package users, is it something you can work on?
from memphis.py.
Related Issues (20)
- Stop consume functionality HOT 7
- Create formal documentation HOT 3
- Bug: Improve error description HOT 6
- Bug: Tries to access property of None instance HOT 2
- Bug: Missing method HOT 2
- Setup automated tests for PRs
- Bug: Review no-member error for ProtoBuf HOT 4
- Bug: Review no-member error for Exception status_code member HOT 6
- Re-enable E1101 message from Pylint
- Raise MemphisSchemaError rather then MemphisError HOT 1
- lint project using Ruff HOT 3
- Use separate connections for producers, consumers, etc.
- Inconsistent consumer name HOT 1
- Add examples to docstrings for consumer methods HOT 6
- Add task count limit to async produce
- Add error handling for async produce
- Drain or cancel waiting tasks when the producer is destroyed
- Support destroying existing consumers
- Change name of async producer parameter to "non-blocking"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memphis.py.