Giter Site home page Giter Site logo

Comments (2)

jjmaldonis avatar jjmaldonis commented on September 15, 2024

Fixed the typo.

@robrua, if a call fails in exectue_request then None gets returned right? What does "fail" mean in this case? Should this instead raise an exception?

from cassiopeia.

robrua avatar robrua commented on September 15, 2024

In this case stats[StatSummaryType.ranked_fives].stats is returning None, so querying it for kills is impossible.

This is the intended behavior - we shouldn't be creating an AggregatedStats object if Riot doesn't send one, and if we started raising exceptions whenever one piece of data is missing you couldn't ever finish a call without an exception.

I think we should just change the example to StatSummaryType.normal_fives for now, as that doesn't cause the same problem and should be more robust to season/name changes that might break the example

from cassiopeia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.