Better protocol detection adding packet length (bits) in addition to timing parameters

[jcarduino]

Better protocol detection adding packet length (bits) in addition to timing parameters

[jcarduino]

I think validation should be done during handling events callback. Made some changes to callback to also take p->bits_per_row. So now we can use bits per row to check for validity.

pmw_d_decode and pmw_p_decode have been changed :

events+=p->callback(p->bits_buffer, p->bits_per_row);

so now bits_per _row are available for usage.

For this a change has been made to structure protocol_state:
int (*callback)(uint8_t bits_buffer[BITBUF_ROWS][BITBUF_COLS],int16_t bits_per_row[BITBUF_ROWS]);

Now you can use the check to exit callback when called and not appropriate.

comments are welcome...

[rct]

I think this is a good idea, and a fairly small change to the current code that will allow callbacks to better validate the message.

I do think a bigger change is required that better uses timing parameters to better classify the signal rather than calling every call back is necessary. But that's a bigger rewrite. In the meantime, just adding the bits per row is a small/worthwhile change to the current code base.

Thanks.

[Batilan]

Please also see my issue #78 I think if we can get the plugin infra implemented also for the PWM decoders we can more easily develop and test this without having to change all plugins. Like @rct mentions bigger changes are probably required to further improve validation of devices and make the software more scalable.

[merbanan]

The new analyzer -A and demodulator configuration makes this better.