Giter Site home page Giter Site logo

Comments (4)

MikeRalphson avatar MikeRalphson commented on September 28, 2024

I assume your first point refers to external references, and only those in that trigger the bug in your other issue (#21). If not, could you please elaborate?

As to your second point, there is no notion of a default behaviour in this extension, because the validate/lint/resolve functionality is all manually selected from the command palette. Users can select a shortcut for whichever behaviour they prefer or just reuse the most recent command.

The reason resolving was not folded into the earlier existing commands was to not change existing behaviour (for example if you are developing an OAS document but have not fleshed out the referenced files yet).

from openapi-lint-vscode.

stevenj avatar stevenj commented on September 28, 2024

Hmm, it must be another extension then that triggers the error. Sorry for the noise. I assumed this extension was running and linting my files automatically.

I appreciate the resolve for external references in your plugin, it stopped me from going insane.

from openapi-lint-vscode.

stevenj avatar stevenj commented on September 28, 2024

No there is definitely something wrong.

I disabled openapi-lint and i get no more openapi lint style errors when i save a file. I re-enabled it and disabled my one other openapi plug in, and if i save a file the lint errors appear.

For example:

!chgemail.yml API/v1/auth
component name invalid

gets listed in the Problems page when i save a file.

I can replicate this if i also run "OpenAPI Validate" manually. So it appears that yes, when I install and enable openapi-lint it is running a openapi validation on save (which is great) BUT its not resolving references, and it should.

Running OpenAPI Resolve and Validate manually reports the document is valid.

On save, if anything is run it should be "Resolve and Validate" it would be great to actually have an option to decide which is run on save "Validate". "Resolve and Validate", "Lint", "Resolve and Lint" or none.

from openapi-lint-vscode.

MikeRalphson avatar MikeRalphson commented on September 28, 2024

Ok, that sounds very reasonable.

from openapi-lint-vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.