Invalid handling of <br> tags

[mermaid-js]

Invalid handling of
tags

[daladim]

Same issue if I use <br> tags instead of <br/> tags

[MindaugasLaganeckas]

This is issue is the same/related to mermaid-js/mermaid-live-editor#26 and can be solved the same way.
@daladim : would you like to work on a PR?

[daladim]

Hi. Thanks for the info.
I am not sure I am experienced enough in JavaScript to make the PR myself, but let's see.

Jihchi has worked around this limitation in mermaid.ink. It is very simple and effective. It indeed is a warkaround, but I can't see any use case where a <br> (that would not be an actual line break) would mistakenly be tampered by this workaround.

Otherwise, since <br>is correct HTML and <br/> is required for XML/XHTML compatibility, we might want to use an XMLSerializer instead of a plain .innerHTML. This would be slightly more complex than the workaround above, but might work as well.

What is your opinion on this?

[MindaugasLaganeckas]

You are welcome to choose the solution yourself. A workaround is good enough, if it is faster to implement. We can always improve things 😄

[MindaugasLaganeckas]

@daladim : thank you so much for your contributions so far. I have tried the svg file with the <br> and it does not give me any error in Firefox. https://github.com/mermaid-js/mermaid-cli/suites/1670560212/artifacts/31151542
The output of svg->png is different than just svg in Firefox for your test file. But no error is shown by the browser.
My Christmas proposal; please, implement the fix, leave the test file, add only a single test (no for loop) and I will gladly accept your contribution. If needed, I will perform a manual verification of the output svg file.

[daladim]

It is strange that you don't get any error in Firefox on your side...
I have just checked the .zip file you mentioned. Both Firefox 83.0 on Ubuntu 20.04 and Firefox 84.0.1 on Windows 10 display the Expected: </br> error on my computer when I open graph-with-br.mmd.svg, and this is the only .svg for which Nautilus does not display a preview...
Anyway, I'll push the fix as you asked asap (and sorry for the Christmas delays!)

[MindaugasLaganeckas]

@daladim : can I close this issue?

[daladim]

Well, this depends on what you think about the associated MR #79 that you've merged.

This merged MR should indeed fix the issue, but you mentioned errors that you kept having. As I can't remember how to test locally (it's been a long time, and I'm not a node/JS expert :-p ) I could not check that master was correct.

To be sure, I can test it if there was a tagged Docker image somewhere.

Please tell me how you want to proceed.
Thanks

[kyww]

Just run this command on the generated svg file as a workaround:
sed 's#<br>#<br/>#g' -i output.svg

[MindaugasLaganeckas]

Fixed by #171

[n0r]

I've just installed mermaid-cli via brew.
When running mermaid-cli against mermaid files containing <br> im still facing this error. @kyww's workaround fixes the previously rendered SVG.