Storm v1.0.5 breaks storm-mesos

[kiryllbondar]

Storm v1.0.5 breaks storm-mesos

[erikdw]

Thanks for the report, I can reproduce this issue, but not sure of any details. If you can determine the root cause that will be helpful otherwise this will not get any attention for weeks if not months.

[erikdw]

This is thematically related to #202 , #214 , #219 , and #222 . Notably, even if we fix #221 (this issue) you will likely still hit #222.

[kiryllbondar]

Thank you a lot. Hope we will have some fix soon

[erikdw]

@kiryllbondar : sorry to be obtuse, but are you saying "we" as in {you, your own team/company} will be providing a fix soon? "We" as in me and my team/company will not be able to work on this for a long time, maybe during Thanksgiving or Christmas time.

[kiryllbondar]

@erikdw : We, I mean all people who use this functionality :) Unfortunately I do not have the skills to deal with this problem on my own.

[erikdw]

@kiryllbondar : thanks for clarifying :)

[JessicaLHartog]

Looking into this, and leveraging the changes in #232 Storm 1.0.5 builds successfully with the Mesos versions in .travis.yml. This breakage in particular is related instead to Mesos 1.4.0.

Looking into this, the following is the result of successive compilations:

Storm Version	Mesos Version	Build Status
1.0.5	1.1.0	Successful
1.0.5	1.1.1	Successful
1.0.5	1.1.3	Successful
1.0.5	1.2.0	Successful
1.0.5	1.2.1	Successful
1.0.5	1.2.2	Successful
1.0.5	1.3.0	Successful
1.0.5	1.3.1	Successful
1.0.5	1.4.0	Unsuccessful
1.0.5	1.4.1	Unsuccessful

This looks to be related to changes in the protobufs for the Mesos version. There's a change in the protobuf version between 1.3.x and 1.4.x, namely that the version is increased to 3.3.0 per this commit

So I updated the protobuf version:

diff --git pom.xml pom.xml
index 2c3a74c..6980b09 100644
--- pom.xml
+++ pom.xml
@@ -120,7 +120,7 @@
       <dependency>
         <groupId>com.google.protobuf</groupId>
         <artifactId>protobuf-java</artifactId>
-        <version>2.6.1</version>
+        <version>3.3.0</version>
       </dependency>
       <dependency>
         <groupId>org.apache.storm</groupId>

And after this change these are the compilation results:

Storm Version	Mesos Version	Build Status
1.0.5	1.1.0	Successful
1.0.5	1.1.1	Successful
1.0.5	1.1.3	Successful
1.0.5	1.2.0	Successful
1.0.5	1.2.1	Successful
1.0.5	1.2.2	Successful
1.0.5	1.3.0	Successful
1.0.5	1.3.1	Successful
1.0.5	1.4.0	Successful
1.0.5	1.4.1	Successful

I'll submit a PR to update the protobuf version.

[JessicaLHartog]

I'll be closing this issue since this is solved once #233 is merged.