meta-rust not appendable from outside

[meta-rust]

meta-rust not appendable from outside

[derekstraka]

The patch should probably be applied against rust-source rather than rust. Does that fix your issue?

[derekstraka]

NOTE: Patching rust with a rust_%.bbappend in another layer works fine on krogoth and master since the removal of shared source.

[zeenix]

The patch should probably be applied against rust-source rather than rust. Does that fix your issue?

You mean the bbappend file should be rust-source.bbappend ? I'm asking cause the patch itself is relative to the source dir. If that is what you meant, I tried that and get the same error and i can still see that source dir is not populated. There is a tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/ dir but it only contains an empty dir named llvm.

[derekstraka]

I can look at it a little closer, but the latest on krogoth allows patching. Is there a technical reason to not move forward?

[zeenix]

Thanks. That's good to hear, shared source is a bit complicated. The focus right now is to get a release out. Once that is done, I'd certainly want to look into not only updating to most recent krogoth at least (or even morty) but also fetching meta-rust from this canonical location.

[derekstraka]

Are you pinned to krogoth for all of your other layers? I'm assume you are not and are missing 4872053. Does it build without your bbappend? I'll need at least your poky and meta-openembedded commits.

[zeenix]

Are you pinned to krogoth for all of your other layers?

AFAICT, no. At least meta-qt5 is stuck on jethrow.

I'm assume you are not and are missing 4872053. Does it build without your bbappend?

On my ubuntu machine (with older gcc), yes it builds fine without the bbappend. Works fine for others too who all use ubuntu for some reason. :-P So I guess that is not the issue?

I'll need at least your poky and meta-openembedded commits.

Sure thing but if you want to reproduce, I'll suggest you simply try building gdp: https://at.projects.genivi.org/wiki/display/GDP/GDP+Master#GDPMaster-RaspberryPi3

Here are the HEADs:

poky: 12eb72ee3b02f826a156ff4e396c770f2b93571e
meta-openembedded: 247b1267bbe95719cd4877d2d3cfbaf2a2f4865a

[derekstraka]

Given the three provided HEADs, it appears to work with rust-source.bbappend from a layer I called meta-test

user@sparta:~/meta-rust/poky$ find meta-test/
meta-test/
meta-test/recipes-devtools
meta-test/recipes-devtools/rust
meta-test/recipes-devtools/rust/files
meta-test/recipes-devtools/rust/files/rust
meta-test/recipes-devtools/rust/files/rust/0001-Fix-build-against-gcc-6.2.patch
meta-test/recipes-devtools/rust/rust-source.bbappend
meta-test/conf
meta-test/conf/layer.conf

user@sparta:~/meta-rust/poky$ cat meta-test/recipes-devtools/rust/rust-source.bbappend
FILESEXTRAPATHS_append := ":${THISDIR}/files"

SRC_URI_append = " \
    file://rust/0001-Fix-build-against-gcc-6.2.patch \
"

And by working, I mean it appears to apply the patches and move forward. The compile fails with

| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/dwarf.c: In function 'dwarf_fileline':
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/dwarf.c:2884:7: error: 'UNUSED' undeclared (first use in this function)
|        UNUSED struct dwarf_data **pp;
|        ^
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/dwarf.c:2884:7: note: each undeclared identifier is reported only once for each function it appears in
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/dwarf.c:2884:14: error: expected ';' before 'struct'
|        UNUSED struct dwarf_data **pp;
|               ^
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/dwarf.c:2886:7: error: 'pp' undeclared (first use in this function)
|        pp = (struct dwarf_data **) (void *) &state->fileline_data;
|        ^
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/dwarf.c: In function 'backtrace_dwarf_add':
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/dwarf.c:3014:4: error: 'UNUSED' undeclared (first use in this function)
|     UNUSED struct dwarf_data **pp;
|     ^
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/dwarf.c:3014:11: error: expected ';' before 'struct'
|     UNUSED struct dwarf_data **pp;
|            ^
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/dwarf.c:3016:4: error: 'pp' undeclared (first use in this function)
|     pp = (struct dwarf_data **) (void *) &state->fileline_data;
|     ^
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/elf.c: In function 'elf_add_syminfo_data':
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/elf.c:440:30: warning: variable 'pp' set but not used [-Wunused-but-set-variable]
|     struct elf_syminfo_data **pp;
|                               ^
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/elf.c: In function 'elf_syminfo':
| /var/build/build/tmp/work-shared/rust-1.7.0-r0/rustc-1.7.0/src/libbacktrace/elf.c:488:33: warning: variable 'pp' set but not used [-Wunused-but-set-variable]
|        struct elf_syminfo_data **pp;
|                                  ^
| make[2]: *** [dwarf.lo] Error 1

[zeenix]

Thanks for testing. Yeah, as I said the patch is known to break the actual build, not fix it. Please feel free to close this ticket for now then. We'll hopefully only add support for gcc6 in GDP after updating meta-rust and hopefully there is no need for a patch in there at all.