chart tooltips are rounding values

[metabase]

chart tooltips are rounding values

[agilliland]

attachment

[agilliland]

+1

[tlrobinson]

Should they be rounded at all, or just raw toString it?

[salsakran]

Hmm. There's a case for smart rounding to a reasonable number of digits if
it's a float.

But there's also something to be said for getting as much info as we have
on a hover. Eg. if I'm hovering over two slices that are 0.88 and 0.87 it
would be good to distinguish between them on hover despite them looking the
same on the pie chart.

On Wed, Jul 29, 2015 at 2:38 PM, Tom Robinson [email protected]
wrote:

Should they be rounded at all, or just raw toString it?

—
Reply to this email directly or view it on GitHub
#588 (comment)
.

[agilliland]

I left some comments on the PR, but IMO the solution progression should be 1) (do now) include the decimal if its part of the value and round it to 2 places, 2) (do later) give the user control to decide this.

The main problem right now is that if someone has a value like 0.78 it's showing as 0 in the tooltip, so we just need to get the accuracy back to a usable state. I don't think most people want to see values like 0.78393973238 so that's why rounding to 2 decimal places seems like a safe approach. Eventually users should be able to control this and decide if they want 1 decimal precision, 3 decimal places, etc.

[salsakran]

That's reasonable, I'll point out that if our default treatment rounds it
to 2 significant places that's a much more robust solution than 2
decimal places, and reduces the number of cases where someone will be
forced to manually intervene and set the number of decimal places. This is
a case where we know enough to DoSmarterThings as we have all the numbers,
their magnitudes, the # of significant figures and # of decimal places in
each. Would much prefer to take advantage of that instead of adding a knob
down the road.

On Wed, Jul 29, 2015 at 3:52 PM, Allen Gilliland [email protected]
wrote:

I left some comments on the PR, but IMO the solution progression should be

1. (do now) include the decimal if its part of the value and round it to 2
   places, 2) (do later) give the user control to decide this.

The main problem right now is that if someone has a value like 0.78 it's
showing as 0 in the tooltip, so we just need to get the accuracy back to
a usable state. I don't think most people want to see values like
0.78393973238 so that's why rounding to 2 decimal places seems like a
safe approach. Eventually users should be able to control this and decide
if they want 1 decimal precision, 3 decimal places, etc.

—
Reply to this email directly or view it on GitHub
#588 (comment)
.

[salsakran]

Think #796 fixes this. If we need to deal with edge cases, we'll pick through them as they come up.