Giter Site home page Giter Site logo

Comments (16)

tlrobinson avatar tlrobinson commented on May 5, 2024 1

Bonus points: it would be pretty neat if when switching from GUI to SQL mode we could pre-populate the SQL editor with the SQL that would be generated by the GUI question. That said, I know the SQL queries we generate can be pretty verbose, so I'm not sure we want to show the user (even power users) "how the sausage is made", so to speak.

from metabase.

snarfed avatar snarfed commented on May 5, 2024

+1!

from metabase.

jgvandehey avatar jgvandehey commented on May 5, 2024

+1

from metabase.

AdamLandis avatar AdamLandis commented on May 5, 2024

+1

from metabase.

salsakran avatar salsakran commented on May 5, 2024

@tlrobinson +100

from metabase.

camsaul avatar camsaul commented on May 5, 2024

Most of the time the SQL we generate is parameterized, e.g. something like

SELECT *
FROM "my.table"
WHERE "my.table.field" = ?

So it's not like you can run the SQL we generate anyway 🙀

from metabase.

salsakran avatar salsakran commented on May 5, 2024

well, presumably, we could take the parameterized sql and insert the parameters in place of the ?. Maybe we could find a javascript model on npm that could deal with that sort of craziness

from metabase.

tmyoon avatar tmyoon commented on May 5, 2024

+1

from metabase.

rossgeesman avatar rossgeesman commented on May 5, 2024

+1

from metabase.

salsakran avatar salsakran commented on May 5, 2024

This has no UX features, so aside from the difficulty of replacing parameterized SQL with the values (via string interpolation), this is ready to be worked on.

from metabase.

agilliland avatar agilliland commented on May 5, 2024

I think there are still some real UX implications with this one. The most obvious of which is where to put the toggle between SQL and GUI mode when it would need to be on the screen at all times. Currently it only needs to be there briefly on a new question and takes the place of several other buttons which aren't relevant on a new question. Or maybe there is a different UI mechanic for making this transition after a GUI card is formed?

We'll also want to be very clear about the UX around what happens after you do this and are looking at the SQL view, such as if there is any way to get back to GUI mode, etc.

from metabase.

salsakran avatar salsakran commented on May 5, 2024

This issue is limited to just the movement from GUI -> SQL and is a one-way transition.

In my mind, the toggle would remain on the GUI query builder. @kdoh + @mazameli, could we take a look at this?

from metabase.

that0n3guy avatar that0n3guy commented on May 5, 2024

+1

from metabase.

gincor avatar gincor commented on May 5, 2024

+1

from metabase.

mazameli avatar mazameli commented on May 5, 2024

Here's a prototype with a proposal for where to put the toggle and how this will all work. Once the prototype loads, click on the flashing blue dot to start the tour:

https://invis.io/WK77GMQM8#/156383432_New_Question

@kdoh @salsakran: let me know if you have any final thoughts.

from metabase.

salsakran avatar salsakran commented on May 5, 2024

I think it works. I would want to revisit the icon placement and reduce the number of different kinds of icons as we get into working on QB3 =)

from metabase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.