Multiple Instances

[metafizzy]

Multiple Instances

[scottbuckel]

Thanks!! Tested and it works as planned!

[lukeshumard]

Tested, and mostly works. I've noticed if I reach the end of one Infinite Scroll, it won't initiate any other. I'll have a look at this today.

[lukeshumard]

Found the bug. Once you've finished scrolling, props.isDone and props.isDuringAjax don't get reset for the next instance of the infinite scroll.

A potential fix might be to change isDone and isDuringAjax to be options instead of properties, so that they can be indexed with each instance of the Infinite Scroll. I'll take a crack at this today and see what I come up with.

[lukeshumard]

Okay, I've resolved this...somewhat. I was getting $(document).ajaxError to fire for each instance of the scroll I had gone through, so I built in a temporary fix that determines if that opts.isDone has already been declared true.

This means that .ajaxError still fires 3 times if you're finishing your third instance of scrolling to the bottom, but at least it doesn't go through the rest of the code unnecessarily. That's why I would consider it to be a temporary fix, until someone can figure out how to properly unbind it.

Here's my revision.
http://lukeshumard.com/misc/infinite-scroll/

For now, here's the modified block.

$(document).ajaxError(function(e,xhr,opt){
if (!opts.isDone) {
debug('Page not found. Self-destructing...');
// die if we're out of pages.
if (xhr.status == 404){
showDoneMsg();
opts.isDone = true;
opts.currPage = 0; // if you need to go back to this instance
$(opts.localMode ? this : window).unbind('scroll.infscr', infscrSetup);
$(document).unbind('retrieve.infscr.'+opts.infid,kickOffAjax);
}
}
});


[paulirish]

with http://pastebin.com you can pst the original.. then "submit a correction"
and after that.
the resulting page will have a Difference link.

nice work btw. :)

[lukeshumard]

http://pastebin.com/diff.php?i=D79Z0neS

there you go! thanks!

[lukeshumard]

spoke too soon. after doing some more testing, i realized that each instance won't become unbound unless it reaches the end. big oops on my part.

working on a fix now.

[lukeshumard]

forgot to mention i sorted this out. i'll send a pull request soon.

[lukeshumard]

Solved in version 1.5.101203

[samcleaver]

I've been away for a while! Looking good Luke, I've added the latest commit which builds on your modification, for some reason the multi-instancing wasn't working correctly with the triggering which I've resolved. I've also added automatic generating of the instance ID when not using manual triggering.

[kkalbat]

Is this change implemented in the latest version of Wordpress plugin? Because when I try multiple instance, it totally crashes. Is there an extra work for defining the the multiple containers and selectors in case of multiple scrollers on the same page?