Giter Site home page Giter Site logo

Comments (20)

lukeshumard avatar lukeshumard commented on April 27, 2024

Just had a thought on this and extensibility. What if the behavior option was a drown that always had default in it, but uploading scripts to a folder called "behaviors" would add options to that list? A similar method to how you upload WP plugins to wp-content/plugins.

from infinite-scroll.

samcleaver avatar samcleaver commented on April 27, 2024

That could work -- although obviously it wouldn't support localMode behaviour and stuff like that? (I presume?)

from infinite-scroll.

samcleaver avatar samcleaver commented on April 27, 2024

Just had a thought that could improve updating etc -- when 2.0 is launched if we have a stable branch the WP plugin could download any behaviours released on here straight from GitHub. i.e. The plugin would download the list of behaviours and would then allow the user to tick which ones to download.

from infinite-scroll.

lukeshumard avatar lukeshumard commented on April 27, 2024

Well, it would support localMode if you uploaded the localMode behavior script into the your behavior folder. After it's uploaded, you would just select "localMode" in the plugin options.

from infinite-scroll.

lukeshumard avatar lukeshumard commented on April 27, 2024

I think the updating idea is good, but I think we should keep this repo strictly for the core stuff. Otherwise, our issues will get cluttered with behaviors that we didn't write ourselves, stuff that isn't necessarily relevant to the plugin, etc. I see behaviors as having their own repos, really.

That said, if the WP plugin could update and get the latest version of our "official" behaviors or whatnot, that would rule. Maybe we can deploy this stuff somewhere?

from infinite-scroll.

samcleaver avatar samcleaver commented on April 27, 2024

I think we should have the "official" behaviours that we support updateable/downloadable within the WP plugin. These would be downloaded either from our repo or via a list (pointing to various repo locations). Obviously third-party behaviours wouldn't be included in the official repo.

@paulirish Would you be able to add me to the plugin authors on Wordpress so I can update/manage it?

from infinite-scroll.

lukeshumard avatar lukeshumard commented on April 27, 2024

Sounds perfect to me!

from infinite-scroll.

samcleaver avatar samcleaver commented on April 27, 2024

Initial revamp completed. Its still missing some of the nice behaviour features I'd like to put in but its definitely a start.
http://wordpress.org/extend/plugins/infinite-scroll/
See changelog for main summary of changes.

from infinite-scroll.

paulirish avatar paulirish commented on April 27, 2024

i just saw this on another plugin.. the "Last Updated: 2010-5-4" is stale.. not sure why since you clearly just updated.

anyway.. the refresh looks great. :) nice work sir

from infinite-scroll.

rfc1437 avatar rfc1437 commented on April 27, 2024

I have a problem with the new version 2.0b2.110617: search pages now correctly work, but category pages show stuff from the main page when you scroll down to the end. See https://hugo.rfc1437.de/category/galerie/ for a case.

from infinite-scroll.

samcleaver avatar samcleaver commented on April 27, 2024

Thanks, I'll get this fixed today.

from infinite-scroll.

samcleaver avatar samcleaver commented on April 27, 2024

@rfc1437 Can you please try downloading https://raw.github.com/paulirish/infinite-scroll/master/wp_infinite_scroll.php and uploading it to wp-content/plugins/infinite-scroll/
I've just made some major changes to the way it determines the url layout that should work for every installation possible. I've tested it as much as I can on my test installation. Let me know if it works! (So I can push out to the Wordpress repo).

from infinite-scroll.

lukeshumard avatar lukeshumard commented on April 27, 2024

I think your pathParse could be constructed differently. If you used some conditional items to build the array instead of just sticking in ?paged=, you could probably do this quite easily.

from infinite-scroll.

samcleaver avatar samcleaver commented on April 27, 2024

Thats what I did in the latest commit :) I'm now using the same method Wordpress use to build its "next post" link.

from infinite-scroll.

rfc1437 avatar rfc1437 commented on April 27, 2024

just tested the new release and that now works fine so far as I can say :)

from infinite-scroll.

paulirish avatar paulirish commented on April 27, 2024

\o/

from infinite-scroll.

cromulus avatar cromulus commented on April 27, 2024

looks like the wordpress upgrade to 3.2 has broken infinite scroll wordpress plugin on the suprmarket.net Grid—A—Licious theme

from infinite-scroll.

samcleaver avatar samcleaver commented on April 27, 2024

@cromulus Do you have a test site I can look at please?

from infinite-scroll.

cromulus avatar cromulus commented on April 27, 2024

yes, http://soultread.com

I have debugging on. It was totally functional right up untill I upgraded to 3.2

from infinite-scroll.

samcleaver avatar samcleaver commented on April 27, 2024

Awesome, thanks. I've had a quick look and it seems very odd! It just doesn't seem to load at all for some reason. I've created a new issue at #73 and have added a link there for a new version of the plugin that would be helpful if you could try.

from infinite-scroll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.