Issue in enabling ilo hardware type

[metal3-io]

Issue in enabling ilo hardware type

[dhellmann]

The host is supposed to be registered with ironic using the boot interface specified by the BMC. See https://github.com/metal3-io/baremetal-operator/blob/master/pkg/provisioner/ironic/ironic.go#L245

If you look at the node in ironic, does it have the right boot interface set?

[ankit-kumar5]

Actually for every driver, boot interface is defined (For Ex: https://github.com/metal3-io/baremetal-operator/blob/master/pkg/bmc/redfish.go#L110)

In my case if i am adding hardware_type ilo, then ir-cond fails to start with the above error. It is not reaching to that point where node creation can happen since ilo doesn't support ipxe boot interface and its being set in default_boot_interface.

[dhellmann]

It sounds like you are saying that the ironic-conductor will not start because a default value, which we don't use, is incompatible with one of the drivers. Is that right?

@dtantsur @juliakreger do you have any insight on this? Should we remove the default boot interface setting, or choose a different one?

[juliakreger]

Greetings,

@ankit-kumar5 You'll need to set the boot interface to the special ilo-ipxe wrapper.... or just get rid of the interface wrapper and declare support for the stock ipxe driver.

https://github.com/openstack/ironic/blob/master/ironic/drivers/ilo.py#L41
https://github.com/openstack/ironic/blob/master/setup.cfg#L70

[ankit-kumar5]

It sounds like you are saying that the ironic-conductor will not start because a default value, which we don't use, is incompatible with one of the drivers. Is that right?

@dtantsur @juliakreger do you have any insight on this? Should we remove the default boot interface setting, or choose a different one?

Yeah.. i am saying that only.

[ankit-kumar5]

Greetings,
@ankit-kumar5 You'll need to set the boot interface to the special ilo-ipxe wrapper.... or just get rid of the interface wrapper and declare support for the stock ipxe driver.
https://github.com/openstack/ironic/blob/master/ironic/drivers/ilo.py#L41
https://github.com/openstack/ironic/blob/master/setup.cfg#L70

Sorry i didnt quite understand by set the boot interface to the special ilo-ipxe wrapper . By this you means setting the default_boot_interface. Am i correct?

I tried the first approach declaring ilo-ipxe as default_boot_interface and it failed because ilo-ipxe is not supported by other hardware types which is obvious that it fails.
For the second approach, i can do that. I was just confirming whether default_boot_interface can be removed from the config or not.

[dhellmann]

We need to be able to add drivers without the user having to customize the default boot interface. If they have to change the default, it's not really a default.

Why won't conductor start with the default set the way it is now?

[ankit-kumar5]

We need to be able to add drivers without the user having to customize the default boot interface. If they have to change the default, it's not really a default.

Why won't conductor start with the default set the way it is now?

Because this default(ipxe) is not supported by ilo hardware type, thats why its failing.

[dhellmann]

Why does ironic care if the default isn't supported by all of the drivers? Why not wait to fail at the point where the boot interface and driver for a given host are both known to be incompatible?

[ankit-kumar5]

We need to be able to add drivers without the user having to customize the default boot interface. If they have to change the default, it's not really a default.

Why won't conductor start with the default set the way it is now?

I will make changes to ilo drivers to support ipxe and pxe boot interfaces.

[juliakreger]

So a few different thoughts:

1. Default is only if a node is created with just a "driver" field, and no other specific interface choices. It is handy, but I'm 99.95% sure the operator, when defining nodes allows all of the interfaces to be defined. If the operator is doing this in two steps against the API, that is likely not ideal.
2. If the list of enabled hardware types includes priority, where the preferred default is the first element in that list, then the "default" can be completely removed. The union of enabled and supported interfaces by the driver will choose the one to use in order of highest to lowest priority.

What I meant by set the boot interface to ilo-ipxe, was to actually do that in the baremetal operator. Similar to how redfish-virtual-media works. See: https://github.com/metal3-io/baremetal-operator/blob/master/pkg/bmc/redfish.go#L132

[ankit-kumar5]

So a few different thoughts:

1. Default is only if a node is created with just a "driver" field, and no other specific interface choices. It is handy, but I'm 99.95% sure the operator, when defining nodes allows all of the interfaces to be defined. If the operator is doing this in two steps against the API, that is likely not ideal.
2. If the list of enabled hardware types includes priority, where the preferred default is the first element in that list, then the "default" can be completely removed. The union of enabled and supported interfaces by the driver will choose the one to use in order of highest to lowest priority.

What I meant by set the boot interface to ilo-ipxe, was to actually do that in the baremetal operator. Similar to how redfish-virtual-media works. See: https://github.com/metal3-io/baremetal-operator/blob/master/pkg/bmc/redfish.go#L132

I have been doing this. You can see here
metal3-io/baremetal-operator@ba6dc38#diff-ce770aa06cd9fa55727a51d6584280b1R70

But its failing way before executing this, when i am adding in conf file(/etc/ironic/ironic.conf)

default_boot_interface = ipxe
default_deploy_interface = direct
default_inspect_interface = inspector
default_network_interface = noop
enabled_boot_interfaces = pxe,ipxe,fake,redfish-virtual-media,idrac-redfish-virtual-media,ilo-ipxe
enabled_deploy_interfaces = direct,fake
enabled_hardware_types = ipmi,idrac,irmc,fake-hardware,redfish,ibmc,ilo
enabled_inspect_interfaces = inspector,idrac,irmc,fake,redfish
enabled_management_interfaces = ipmitool,idrac,irmc,fake,redfish,idrac-redfish,ibmc,ilo
enabled_power_interfaces = ipmitool,idrac,irmc,fake,redfish,idrac-redfish,ibmc,ilo
enabled_raid_interfaces = no-raid,irmc,agent,fake
enabled_vendor_interfaces = ipmitool,no-vendor,idrac,fake,ibmc,ilo

[juliakreger]

Remove the default_boot_interface line, and change the enabled_boot_interfaces to:

enabled_boot_interfaces = ipxe,pxe,fake,redfish-virtual-media,idrac-redfish-virtual-media,ilo-ipxe

It will have the same effective configuration for all users and you'll be able to explicitly ask for ilo-ipxe.

[ankit-kumar5]

Remove the default_boot_interface line, and change the enabled_boot_interfaces to:

enabled_boot_interfaces = ipxe,pxe,fake,redfish-virtual-media,idrac-redfish-virtual-media,ilo-ipxe

It will have the same effective configuration for all users and you'll be able to explicitly ask for ilo-ipxe.

Thanks @juliakreger.. I was asking for this clarification only.

[stbenjam]

/kind feature

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[metal3-io-bot]

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

[metal3-io-bot]

@metal3-io-bot: Closing this issue.

In response to this:

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.