Comments (10)
@diegopradogesto - Thank you very much for reporting this & for the tips on how to fix - I sincerely appreciate it =).
I've committed some changes to the qml on the develop branch here that will hopefully fix the issue that you're reporting. Unfortunately I haven't yet been able to duplicate the issue myself. Changing the display scaling on a Windows 10 laptop with no second monitor seems not to show this behavior at 100%, 125%, 150% and 175%.
I'll try adding a second monitor to the mix, and keep working on it to see if I can find a system to reproduce the text scaling issue on - once I can confirm that it's fixed I'll submit an update to the plugin.
Cheers!
from cura-dremel-printer-plugin.
I'll try to reproduce it again today in my computer. I'll let you know if the issue is still there.
from cura-dremel-printer-plugin.
Apparently it didn't work for all the text in the checkboxes. I made some comments in the commit and removing the qsTr
in the checkboxes' text seems to work for me. Also adding a renderType
property does nothing in the checkbox, it is only available in Labels.
from cura-dremel-printer-plugin.
Thanks for taking the time to help me test this @diegopradogesto
Per your testing I've removed all qsTr
calls within the qml file, and cleaned up the preferences dialog (commit is here). I'll test on a few more machines this weekend, both with and without external monitors and hopefully I'll be able to find one that I can duplicate the behavior on to verify that I fixed it.
The new preference dialog should look like this if everything renders correctly:
Cheers!
from cura-dremel-printer-plugin.
Looks fine now. I'm closing this issue then.
BTW, this is an off-topic but you probably realised that your plugin is not available in Ultimaker Cura 3.6 anymore. That is because we had and internal issue that didn't allow to use the same plugin for different SDK versions. However we did a fix for this and maybe you can resubmit your plugin with those changes. You can take a look in this documentation:
- https://github.com/Ultimaker/Cura/wiki/CuraAPI-and-SDK-Versions
- https://github.com/Ultimaker/Cura/wiki/plugin.json
Please let me know if I can help with that.
from cura-dremel-printer-plugin.
@diegopradogesto - I cannot thank you enough for reporting & subsequently helping to test this issue out. - I sincerely appreciate your time & efforts. I've credited you as a contributor in the README - Thank you!
I (or rather, one of the users of this plugin) had noticed that the plugin disappeared from the Cura 3.6 marketplace and I figured that I had just released too soon, so thanks for the information. Typically I try to follow the style of the GcodeWriter plugin but that plugin doesn't seem to use the new supported_sdk_versions
field, and I'm having difficult getting Cura 3.6 to recognize the 0.5.6 version of the plugin as a standalone release. Here's what I've tried so far:
- Adding the the line
"supported_sdk_versions": ["5", "6.0.0"],
to my plugin.json while leaving the"api": "6.0",
line alone - Cura 3.6 didn't recognize the plugin as installed - Adding the the line
"supported_sdk_versions": ["5", "6.0.0"],
to my plugin.json while leaving the"api": "5",
line alone - Cura 3.6 didn't recognize the plugin as installed - Adding the the line
"supported_sdk_versions": ["5.0.0", "6.0.0"],
to my plugin.json while leaving the"api": "5",
line alone - Cura 3.6 didn't recognize the plugin as installed
Internal to the new upcoming version 0.5.6 of the plugin I've added lines that call Cura's built in Snapshot() functionality (which I believe is new to cura 4, but feel free to correct me) and removed my old hacked screenshot code, so I'm probably best off leaving the "supported_sdk_versions": ["6.0.0"],
as version 6 only.
In a month or so once Cura 4 comes out supporting Cura 3.6 shouldn't be an issue, and I doubt that there are too many inconvenienced users currently, - but I'd be willing to re-release the plugin for 3.6 if I can test it before I release - if you've got any tips as to what I need to do I'd be happy to hear them
Once again - Thanks again for your help. I'll submit version 0.5.6 with the blurriness fixes soon. If I can make it work with Cura 3.6 that'd be great, but if not then I'll just submit it for Cura 4 and any user who really needs the 0.5.3 version of this plugin for Cura 3.6 can download it from the releases page here
from cura-dremel-printer-plugin.
Thanks for the credits, I think adding more functionality to Cura is always better for us and also for you. So, thank you for the contribution.
Asking your questions:
- Yes, you're right, the GCodeWriter plugin is not really updated and still uses the deprecated "api" field. We have to change it.
- To make your plugin work with both 3.6 and 4.0, you need to do this in your plugin.json (that is something like option 3, maybe you need to keep the "api" using a integer):
{
...
"api": 5,
"supported_sdk_versions": ["5.0.0", "6.0.0"]
...
}
- The Snapshot functionality was added before 3.5, so it should work in your plugin. If not, you can do two things:
- Keep your plugin only available for 4.0, using only
"supported_sdk_versions": ["6.0.0"]
. - In your code, you can check for the SDK version and use an if-statement to do different things depending on the version.
Let me know if that works and if I can help you further.
from cura-dremel-printer-plugin.
Thanks for the info - I've been able to test on 3.6 and 4.0 and have been successful on both. To do so I made two releases of ver 0.5.6 of the plugin that work on Cura 3.6 and 4.0 respectively. To do so I had change the plugin.json to the following between the two versions:
For Cura 3.6:
{
...
"api": 5,
"supported_sdk_versions": ["5.0.0", "6.0.0"],
...
}
For Cura 4.0:
{
...
"api": "6.0",
"supported_sdk_versions": ["5.0.0", "6.0.0"],
...
}
If I tried setting api": 5
for Cura 4.0 the plugin doesn't load (at least not on the released Cura 4.0 beta) - maybe this has changed in the post-release 4.0 beta code? Either way - my question is which version should I post to contribute.ultimaker.com in order to have the plugin work for both versions? Thanks
from cura-dremel-printer-plugin.
You only need to do one release with
{
...
"api": 5,
"supported_sdk_versions": ["5.0.0", "6.0.0"],
...
}
The problem in Cura 4.0 beta is that the feature was not ready, that's why it doesn't work. I can provide a nightly build for you or just upload it in the contribution portal and I will test it in both versions.
from cura-dremel-printer-plugin.
Thanks again for all your help - I've submitted the plugin - feel free to let me know if you find any issues. Cheers!
from cura-dremel-printer-plugin.
Related Issues (20)
- Plugin DremelPrinterPlugin was not loaded because it could not be verified. HOT 4
- Updated branded build plate for 3D45 HOT 1
- Cura 5.4 "Unable to Slice" error due to missing minimum speed (3D45, 3D40) HOT 1
- 3D45 Does not preheat before starting HOT 5
- A version for 3D45 would be great HOT 6
- Mime type error when saving to removable drive after installing CuraBlender plugin HOT 11
- I have a 3D45 for you - drop me a line to [email protected] ! thanks HOT 14
- No Dremel printer available in printers list HOT 4
- cura 4.91 not loading dremel plugin HOT 5
- Acceleration Enabled by Default? HOT 11
- Remote monitoring camera 3d45 HOT 26
- Dremel Plugin doesn't work with Cura 5.0
- Cura Doesn't find printer when selecting "Add Printer by IP Address" HOT 3
- Request to pull printer definitions into Cura HOT 1
- "There are no file formats available to write with" HOT 4
- Small artifact at edges of calibration cube on the "X" face at the top and bottom of the "X" HOT 1
- Problems printing temperature tower on 3D45 HOT 20
- Add helpful comments to resulting gcode
- End G-code in machine settings causing issues
- Serial Connection Fails HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cura-dremel-printer-plugin.