Wrong return value for eth_requestAccounts

[metamask]

Wrong return value for eth_requestAccounts

[danfinlay]

Yes, this would've been a breaking change, and so there was a very recent change to EIP-1193:

• The current send() behavior which returns Promise<{ results: <any> }> will remain.
• A new method request() will be added, which returns the intended result Promise<any>.

https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1193.md

So this is indeed a problem with he docs: @BboyAkers is correct, and we should change to match his description.

[andy0130tw]

Yes. I just wanted to point out a mistake of documentation and it might lead to confusion when adapting MetaMask's provider with other frameworks like web3.js. Even the examples are incorrect.
I believe the current behavior is a design choice to be EIP-1193 compliant.

[BboyAkers]

I'll create a pull request and change it in the docs

[BboyAkers]

@jennypollack @danfinlay any idea on this? 🙂

[BboyAkers]

@andy0130tw it seems that if you do response.results, it will give you the array you're wanting. Are you expecting the array to be at the base of the response?

[BboyAkers]

Pull request made! #83