[Bug] Ledger account disappears

[plasmacorral]

[Bug] Ledger account disappears

[dawnseeker8]

I am unable to replicate this issue with multiple transaction submit, however, the only time i can make the ledger account disappear is doing following: (very similiar issue with #8693)

1. install the fresh metamask mobile in android. (must be fresh MMM app)
2. restore a account using SRP.
3. when account appear. click the account, and bring up the account drop down list.
4. select Add account and hardware wallet -> Add hardware wallet
5. Select ledger and then allow all permission required.
6. and then add a ledger account in MMM.
7. Now you can close MMM and relaunch metamask. (or wait for screen lock and reactive to force user relogin)
8. After user login again. you will notice ledger account disappear in the list.

After deep into detail about the issue and debug the code. i can confirm that this issue has same cause as #5721 (the behaviour is difference however, they all touch the same flow in vault.js during login and reset password).

and this account disappear issue only happen at the first time you relogin to MM either from lock screen or from relauch the app. and it wont happen in the second time. that is because the first time user login, the code inside authentication.ts will recreateVaultWithSamePassword due to ENCRYPTION_LIB in asyncStorage have value of null. and after the first time user login, ENCRYPTION_LIB will have value set. and the next time user login, system wont run recreateVaultWithSamePassword. that is why second time account wont disappear.

anyway, i have tested the fix for PR for fixing #5721 , and confirm the fix will fix above issue. i will link this issue to above PR.

[angelcheung22]

Lets test this one again after the other PR got merged, and see if issue still exist. Onhold for now