Comments (18)
I figured out that it's not a right/bottom margin - it's a scrollbar, created by overflow-y: scroll!important;
. But I still can't understand how two identical apps can render differently.
UPD1: Looks like the issue was caused by Semantic-UI latest version. They moved from normalize.css 3.0.1 to normalize.css 7.0.0.
UPD2: Just found the problem: in [email protected](July 11) was added:
body ::-webkit-scrollbar {
width: 10px;
}
So by default size of the scrollbar is 10px.
You can quickly patch this with:
body ::-webkit-scrollbar {
width: 0px;
}
from suicrux.
@TheDolo
I have the same issue here. One of my Macs is behaving fine when displaying the app via Chrome, the other iMac has the same issue as yours. Why is it?
from suicrux.
@TheDolo @PharrellWANG Thanks for the report, I'll check this issue later, currently working on advanced images preprocessing.
from suicrux.
Heh, this removes the scroll bar for me lol! The bottom margin is still visible with the above too.
from suicrux.
Just change in src/common/containers/App/style.jsx
from:
export const SidebarSemanticPusherStyled = styled(Sidebar.Pusher)`
height: 100%;
overflow: scroll!important;
-webkit-overflow-scrolling: touch;
to:
export const SidebarSemanticPusherStyled = styled(Sidebar.Pusher)`
height: 100%;
overflow-y: scroll!important;
-webkit-overflow-scrolling: touch;
This fixes will be in the next minor version, sorry for no updates for so long
from suicrux.
This fixes the bottom bar for me, however the right bar still does not auto hide (like the demo), and has a background color that is different from the rest of the page (part of the auto hide problem, like in the pictures above).
Thank you!
from suicrux.
did you insert code from this comment into your styles?
from suicrux.
The scrollbar is no longer visible when scrolling across the entire app for all components when I insert that into global.jsx, but the background color is gone. I also tested on a fresh clone, same result.
from suicrux.
It's because some semantic's style still aren't reseted. Will be fixed too
from suicrux.
@TheDolo probably fixed in 364fa41
from suicrux.
:( I have no scrollbar on both dev and build, but I can still scroll. I don't get why your online demo is fine! Shift refresh doesn't help. I dug up these up though!
https://github.com/Semantic-Org/Semantic-UI-React/blob/master/docs/app/Components/DocsLayout.js#L55
https://github.com/Semantic-Org/Semantic-UI-React/blob/master/docs/app/Components/Sidebar/Sidebar.js
Edit: No scrollbar on demo site too, sometimes. yea something is up with refresh/resetting ugh.
from suicrux.
@TheDolo, sorry can investigate your issue only in next 45 minutes :(
from suicrux.
Doesn't need to be today! It probably affects everyone using this boilerplate, I'd be grateful for any fix any time you can for this one!
Edit: *I said sidebar, I mean't the right body scrollbar is missing with this code (but I understand why you do this line!)
body ::-webkit-scrollbar {
width: 0px;
}
from suicrux.
@TheDolo oh, I've just understood that you meant scrollbar, I didn't understand how sidebar can disappear from the page :)
Currently, I find only 3 ways to fix this problem:
- use custom semantic.css build (bad solution)
- use this scrollbar (bad solution)
- hide scrollbar at all (right now the best solution)
I continue to investigate this issue, probably there is any better solution than just hide this.
from suicrux.
Hi @TheDolo @PharrellWANG
I can't reproduce the issue, is it still actual?
from suicrux.
Looks like scrollbar styles were removed from SUI core
from suicrux.
Boom! This thread just saved my butt.
from suicrux.
from suicrux.
Related Issues (20)
- Stuck at Login `auth` screen HOT 2
- NextJS integration HOT 9
- Basic Setup ? HOT 1
- The script has an unsupported MIME type ('text/html'). HOT 2
- Source Map Issue HOT 2
- sidebaritem titles are shown on header when page is refreshed HOT 6
- Deploying application with apache, frontend does not show... HOT 5
- Who's using Suicrux? HOT 9
- Roadmap [WIP]
- Eager to see Redux-Saga in this project HOT 1
- flow-typed install fails HOT 1
- Error Can't resolve 'react-tree-walker', while running "npm run dev" from master branch HOT 2
- Version 10 of node.js has been released
- static only? HOT 1
- Unable to debug in VSCode editor HOT 1
- An in-range update of webpack-hot-middleware is breaking the build 🚨 HOT 3
- An in-range update of babel-plugin-styled-components is breaking the build 🚨 HOT 1
- An in-range update of react is breaking the build 🚨 HOT 31
- An in-range update of enzyme is breaking the build 🚨
- An in-range update of eslint-plugin-react is breaking the build 🚨 HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from suicrux.