Giter Site home page Giter Site logo

Comments (18)

Metnew avatar Metnew commented on May 2, 2024 4

I figured out that it's not a right/bottom margin - it's a scrollbar, created by overflow-y: scroll!important;. But I still can't understand how two identical apps can render differently.

UPD1: Looks like the issue was caused by Semantic-UI latest version. They moved from normalize.css 3.0.1 to normalize.css 7.0.0.

UPD2: Just found the problem: in [email protected](July 11) was added:

body ::-webkit-scrollbar {
    width: 10px;
  }

So by default size of the scrollbar is 10px.
You can quickly patch this with:

body ::-webkit-scrollbar {
    width: 0px;
  }

from suicrux.

PharrellWANG avatar PharrellWANG commented on May 2, 2024

@TheDolo
I have the same issue here. One of my Macs is behaving fine when displaying the app via Chrome, the other iMac has the same issue as yours. Why is it?

from suicrux.

Metnew avatar Metnew commented on May 2, 2024

@TheDolo @PharrellWANG Thanks for the report, I'll check this issue later, currently working on advanced images preprocessing.

from suicrux.

 avatar commented on May 2, 2024

Heh, this removes the scroll bar for me lol! The bottom margin is still visible with the above too.

from suicrux.

Metnew avatar Metnew commented on May 2, 2024

Just change in src/common/containers/App/style.jsx
from:

export const SidebarSemanticPusherStyled = styled(Sidebar.Pusher)`
	height: 100%;
  overflow: scroll!important;
 -webkit-overflow-scrolling: touch;

to:

export const SidebarSemanticPusherStyled = styled(Sidebar.Pusher)`
	height: 100%;
        overflow-y: scroll!important;
        -webkit-overflow-scrolling: touch;

This fixes will be in the next minor version, sorry for no updates for so long

from suicrux.

 avatar commented on May 2, 2024

This fixes the bottom bar for me, however the right bar still does not auto hide (like the demo), and has a background color that is different from the rest of the page (part of the auto hide problem, like in the pictures above).

Thank you!

from suicrux.

Metnew avatar Metnew commented on May 2, 2024

did you insert code from this comment into your styles?

from suicrux.

 avatar commented on May 2, 2024

The scrollbar is no longer visible when scrolling across the entire app for all components when I insert that into global.jsx, but the background color is gone. I also tested on a fresh clone, same result.

from suicrux.

Metnew avatar Metnew commented on May 2, 2024

It's because some semantic's style still aren't reseted. Will be fixed too

from suicrux.

Metnew avatar Metnew commented on May 2, 2024

@TheDolo probably fixed in 364fa41

from suicrux.

 avatar commented on May 2, 2024

:( I have no scrollbar on both dev and build, but I can still scroll. I don't get why your online demo is fine! Shift refresh doesn't help. I dug up these up though!

https://github.com/Semantic-Org/Semantic-UI-React/blob/master/docs/app/Components/DocsLayout.js#L55

https://github.com/Semantic-Org/Semantic-UI-React/blob/master/docs/app/Components/Sidebar/Sidebar.js

Edit: No scrollbar on demo site too, sometimes. yea something is up with refresh/resetting ugh.

from suicrux.

Metnew avatar Metnew commented on May 2, 2024

@TheDolo, sorry can investigate your issue only in next 45 minutes :(

from suicrux.

 avatar commented on May 2, 2024

Doesn't need to be today! It probably affects everyone using this boilerplate, I'd be grateful for any fix any time you can for this one!

Edit: *I said sidebar, I mean't the right body scrollbar is missing with this code (but I understand why you do this line!)

body ::-webkit-scrollbar {
    width: 0px;
  }

from suicrux.

Metnew avatar Metnew commented on May 2, 2024

@TheDolo oh, I've just understood that you meant scrollbar, I didn't understand how sidebar can disappear from the page :)
Currently, I find only 3 ways to fix this problem:

  1. use custom semantic.css build (bad solution)
  2. use this scrollbar (bad solution)
  3. hide scrollbar at all (right now the best solution)
    I continue to investigate this issue, probably there is any better solution than just hide this.

from suicrux.

Metnew avatar Metnew commented on May 2, 2024

Hi @TheDolo @PharrellWANG
I can't reproduce the issue, is it still actual?

from suicrux.

Metnew avatar Metnew commented on May 2, 2024

Looks like scrollbar styles were removed from SUI core

from suicrux.

Duder-onomy avatar Duder-onomy commented on May 2, 2024

Boom! This thread just saved my butt.

from suicrux.

Metnew avatar Metnew commented on May 2, 2024

@Duder-onomy 👍

from suicrux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.