Giter Site home page Giter Site logo

Comments (6)

GoogleCodeExporter avatar GoogleCodeExporter commented on September 2, 2024
Work has started. Open issues:

* remove package webapp.formater and replace with RIO [1] code. The only "own" 
formatter we have is the HTML formatter. This class rewritten as an impl. of 
RDFWriter in Sesame.  Then, we could hook it in Sesame, so that we have 
something like:

RDFFormat html_writer = Rio.getWriterFormatForMIMEType("text/html");

* check/update JUnit-tests
* and there are still some NxParsers used in: NodeTypeSerializer, LoadServlet, 
Util class //but this should be only minor changes

@Andrea: Feel free to add/change/remove above TODOs ;)

Kind regards
Andreas

Original comment by andreas.josef.wagner on 26 Jan 2014 at 12:23

  • Changed state: Started

from cumulusrdf.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 2, 2024
Hi, 
are NodeTypeSerializer and DoubleTypeSerializer used somewhere? Because the 
factory method in Util (guessSerializer) never has a chance to reach the create 
statement for both of them. SerializerTypeInferer from hector API always 
returns something, never null so the check if (ser == null) always returns 
false. 

In addition DoubleTypeSerializer is associated with Double.class and 
double.class but the default Hector serializer already does.

Can we remove those two classes?

Original comment by [email protected] on 27 Jan 2014 at 8:13

from cumulusrdf.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 2, 2024
Sorry, that was my comment with a wrong account.

Original comment by [email protected] on 27 Jan 2014 at 8:29

from cumulusrdf.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 2, 2024
Hi Andrea, you are right. Both of them are no longer needed - I just checked. 

Thanks :)
Andreas

Original comment by andreas.josef.wagner on 27 Jan 2014 at 10:56

from cumulusrdf.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 2, 2024
This issue was closed by revision r801.

Original comment by [email protected] on 29 Jan 2014 at 3:11

  • Changed state: Fixed

from cumulusrdf.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 2, 2024
Short description of changes:

1) pom.xml
The nx dependency has been removed but there was a transitive dependency that 
now is directly imported: commons-cli:commons-cli:1.2

2) NodeTypeSerializer has been removed 
3) Utils.guessSerializer is a (at moment unuseful, I believe) wrapper around 
SerializerTypeInferer
4) DoubleTypeSerializer hasn't been removed because needed somewhere.
5) Environment.RDFFileExtensions has been removed. RDFFormat is used instead
6) Environment.RDFSerializationFormats has been removed. RDFFormat is used 
instead
7) Minor modifications on Dump and Load from cli package for replacing the 
format (from String to Sesame RDFFormat)
8) AbstractCassadraRdfHector: minor modifications for replacing the format 
(from String to Sesame RDFFormat)
9) CumulusRDFIterator: removed an unused nx references
10) CumulusRDFSailConnection: removed nx references
11) CumulusRDFValueFactory: removed nx references
12) Util: removed nx references + introduced some compose methods in order to 
avoid redundancy. There are some TODO for logging that will be fixed in #25
13) LoadServlet: removed nx references
14) TriplePatternServlet: removed nx references
15) HTMLFormat: in the print method there's a temporary CharArrayWriter that 
encodes nt triples (otherwise Tidy was not happy with the result html)
16)  NTriplesFormat: added startRDF and endRDF calls to RDFWriter that caused 
test failures ("Document writing has not been started yet") 
17) SimpleRDFXMLFormat: added startRDF and endRDF calls to RDFWriter that 
caused test failures ("Document writing has not been started yet")
18) test package: added some minor modifications for adapting test cases. 

Original comment by [email protected] on 29 Jan 2014 at 3:12

from cumulusrdf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.