Comments (9)
I thought I fixed this one already...it keeps coming back.
from mgba.
Ah so I wasn't crazy! I didn't realize you had a GitHub account or I would have tagged you. I was discussing this with beware on the gbdev Discord and he said that the SGBC implementation in bgb is kind of ad hoc and not necessarily known to be well behaved, so we agreed to clean it up to make it more consistent. Hopefully it'll lead to it being caught before release if it regresses again.
from mgba.
I remember now. This is actually a bug in Crystal Clear. I'm pretty sure it was fixed at some point. I backed out the patch that fixed it (8a87eaa) because it was clearly erroneous to include. It's not real hardware so there's no "well defined" way to do this, but it was special casing for one ROM hack so I didn't want to keep it. I guess bgb decided to leave that special casing in.
Please use an up-to-date version of Crystal Clear to confirm.
from mgba.
I tried it with the latest patch (2.5.10), I didn't find the files for 2.5.9 so I couldn't try it with the older one. I tried both, the normal version and the color filter version. I tried it on my current mgba installation and on the latest development build. The bug still persists
from mgba.
Hmm, alright, I'll take a closer look.
from mgba.
Reverting the reversion fixes it. Ugh. Looks like Crystal Clear still has the bug. I need to figure out if I work around their bug or pressure them to fix it instead.
from mgba.
No need for any pressure. I agree that mGBA should not have any special handling just for one hack. I thought I had fixed this on my end as of CC 2.5.3 by disabling OBJs when updating the border, but I've just checked both that version and the latest against mGBA 0.10.3 and I'm able to replicate this. I guess either I didn't properly fix this, or if I did, it was only partially, since updating the border seems to work correctly in most other places.
I've made a note of this, and I'll see if I can work it out before the next version. I apologize for any confusion and appreciate your insight into figuring this out.
from mgba.
@ShockSlayer While looking into this last night, beware noticed that you don't set BGP to $e4. Since this is a GBC-only game and that's a GB-only register that makes sense, but the SGB requires that for VRAM transfers to work properly. I don't think we're going to enforce that in SGBC, but it would be appreciated if you set it once on startup just for good measure, as that's what licensed titles that happen to upload borders in GBC mode do.
from mgba.
Cool. I'll make a note of that as well.
from mgba.
Related Issues (20)
- Load external savefiles into mGBA 1-4 save slots HOT 4
- cant remap fast forward bind HOT 1
- Assigning a key to uncapped framerate speed doesn't save and must assign again each time I restart the emulator
- [libretro] Saving on Switch didn't get persisted to disk HOT 3
- Cannot select shaders within mGBA HOT 4
- Rich Presence issue HOT 2
- 'Lock frame size' isn't followed on first start HOT 1
- mGBA won't open and crashes. HOT 1
- [GBC] Issues playing the homebrew video player GBVideoPlayer2
- mgba does not allow background input HOT 3
- mGBA-qt crashes on startup
- controls remap for ''select'' and ''start'' to x/y keep resetting to default HOT 5
- Some gbc games don't display properly in sgb mode HOT 1
- "Classic NES Series - Zelda II: The Adventure of Link" soft-freezes during ending HOT 2
- Null handling differs between Windows/x86 and OSX/ARM HOT 10
- ELFs made with HAM (GCC 3.2.2) not detected as ELF HOT 2
- How can I provide useful information when the MacOS version crash while emulating games? HOT 1
- My emulator crashes when i try an encounter in Pokemon Unbound
- [GBC] Infinity demo #1 (2024-08-30): Graphical glitch when moving the window color sliders
- Windows 11 has rounded corners HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mgba.