Giter Site home page Giter Site logo

Comments (3)

mgechev avatar mgechev commented on May 21, 2024

During the last meeting, we decided to use the CssSelector and it's parse method from @angular/compiler. This way we'll be able to have semantical check based on the selector type.

For instance, for @Components the check should look like:

const selector = CssSelector.parse(component.selector);
if (selector.element !== null) {
  // validate if it is a valid kebab-case elector, if not, throw a warning
} else {
  // throw a warning that the component doesn’t use element selector
}

Problem that needs to be considered if a mixture is used (i.e. component with element and attribute/class selector, etc.). We need to make sure we're aligned with the style guide.

from codelyzer.

preslavsh avatar preslavsh commented on May 21, 2024

#137 Needs reviewing

from codelyzer.

mgechev avatar mgechev commented on May 21, 2024

Fixed by 3373dff.

from codelyzer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.