Few bugs to fix

[mgravell]

Few bugs to fix

[mgravell]

• Over disposing

the first is not over-disposed; see just before the return in the success case where it nukes the things (having transferred disposal ownership to result:

            Method = Path = HttpVersion = default(ReadableBuffer);
            Headers = null;

• Copying data into a readable buffer

              if ((len + WebSocketKeySuffixBytes.Length) > buffer.Length) throw new ArgumentException("Oversized key", nameof(key));
  

(note that the buffer is initialized with an Alloc that gives it more than enough than we need for this scratch area)

• Should this be more graceful

Yes

• GetRaw and GetInt32

Nice; will do

• Dispose the HttpRequest after making the socket object

No; I use it in CompleteHandshakeAsync, and (oops) it should be available in OnAuthenticateAsync . It is already disposed via using when I am done with it.

[mgravell]

Note: a method called uint GetInt32() sounds... wrong. GetUInt32() ?

[davidfowl]

the first is not over-disposed; see just before the return in the success case where it nukes the things (having transferred disposal ownership to result:

Ah! subtle...

(note that the buffer is initialized with an Alloc that gives it more than enough than we need for this scratch area)

The danger is that blocks are shared and you don't want to write into a slice of data you don't own. This is an interesting scenario though. Need to think through this one...

Note: a method called uint GetInt32() sounds... wrong. GetUInt32() ?

Yea it should be Uint32 😄 .

[mgravell]

But surely if I'm writing into a chunk that I obtained via Alloc with a minimum size, I know I'm OK as long as I don't screw up the offsets? I do check that we have enough in the span from the Alloc - am I missing something?

[mgravell]

if the issue is that I need to call Ensure(), I can do that - but I thought that was implicit from an Alloc with minimum size

[davidfowl]

Wait, I'm blind. I thought you were writing into the ReadableBuffer this is fine. 😄