Comments (8)
Hmm just about to start my day, but looks like https://github.com/mhartington/deoplete-typescript/blob/master/rplugin/python3/deoplete/sources/typescript.py#L139
is causing the issues. @DonnieWest added this.
from nvim-typescript.
@mhartington I can look into it tonight. It looks like after removing that check, it still fails everywhere else that uses string indices.
from nvim-typescript.
Reverting back to before my changes still errors out with a similar error here https://github.com/mhartington/deoplete-typescript/blob/dd582eaa74e275c7ec630b4d1b70056cd4ea82e5/rplugin/python3/deoplete/sources/typescript.py#L153
Even fixing some of the errors, it looks like the response from Typescript 2.0 is different enough to display wrong completions. I can push up some of these fixes, but I think I'd prefer to error out on 2.0 instead of giving out the wrong information.
I don't know enough about tsserver to be able to debug this. I'd suggest someone else head this up, but if I get some time I might give it a shot
from nvim-typescript.
This may be of use: https://github.com/Microsoft/TypeScript/blob/v2.0.0-beta/src/server/protocol.d.ts
from nvim-typescript.
I'll poke around and see what up. I personally don't use 2.0 since it's still beta.
Might be worth just grabbing our own copy of the tsserver code and bundling it with the code base for future releases.
from nvim-typescript.
I started using 2.0 because @types are much less horrible (no more ///).
In an ideal world where we all got paid to work on OSS projects, I'd suggest the plugin sniffs for the available TSS version and adjusts it's response handling based on that.
Bundling the server would make it break for code written for a different compiler, only in new and interesting ways
from nvim-typescript.
Hmm, this should be do-able. Hopefully.... we'll just drop support for 1x version of tss once 2.0 is stable and is no longer in beta.
Will try to look into this tonight!
from nvim-typescript.
Yeah, TS seems to move rather fast, and the improvements are often worth the upgrade pain.
from nvim-typescript.
Related Issues (20)
- `:TSGetCodeFix` does not work when diagnostics are disabled HOT 2
- Disable drawing diagnostics in buffer? HOT 1
- Previewing typescript file from Nerdtree
- TS errors in non-ts files
- feature request: tooltips on hover (I mean, hovering with the cursor, not the mouse) HOT 2
- TSDoc is not in a preview window
- TSRename resets unsaved buffer to saved states and breaks undo HOT 1
- Quickfixlist of TSRename resizes other windows HOT 1
- Errors when editing a TS file after a few minutes HOT 14
- UpdateRemotePlugins fails to register nvim_typescript HOT 1
- TSDef is doing nothing or fails silently. HOT 6
- Error about non-existent type, yet the type is referenced in another error HOT 1
- Pre-build JS package
- Stuck floating windows HOT 3
- Error Invoking TSOmniFunc: No content available HOT 1
- Omni completion inconsistent with deoplete HOT 9
- Deprecate yats as official syntax in favor of NeoVim's HOT 4
- Diagnostic runs on whole vue file instead of <script> part only
- Will this plugin support yarn 2 without node_modules directory? HOT 1
- Not an editor command: TSStop HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nvim-typescript.