ingognito and window size setting

[mherrmann]

ingognito and window size setting

[danbaghilovici]

Helium has two functions : set_driver() and get_driver(). You can use a new selenium driver with the given arguments options to start helium with that given driver. For example :

from helium import *
from selenium import webdriver

chrome_options = webdriver.ChromeOptions()
chrome_options.add_argument("--incognito")
chrome_options.add_argument("--window-size=600,300")
# or max
# chrome_options.add_argument("--start-maximized")
driver = webdriver.Chrome("./chromedriver", options=chrome_options)
set_driver(driver)
get_driver()
go_to("google.com")

After calling set_driver() there is no need to call start_chrome() since set_driver() already starts the given driver. Hope it helped.
I will probably add a PR later for suggesting that start_chrome() or start_firefox() take extra arguments for setting the drivers.
EDIT : code format

[mherrmann]

Thank you @dntzbgh! Re the pr: before you spend time on this, could you explain why it would be better than set_driver?

[danbaghilovici]

I guess its more straightforward than creating the driver instance with selenium and then setting it up with set_driver(). It will be much easier just to pass the arguments into start_chrome(url, options).

[punasusi]

I don't think such a PR would give any technical benefits, but it would certainly be much more usable to just set any extra arguments directly in start_chrome(url, options).

[mherrmann]

Yeah, makes sense. Do you think you could add it for start_firefox too @dntzbgh ?

[danbaghilovici]

Hi, sorry for such a late response.
After thinking it better I think that what you have said in #9 makes sense. There are too many options and parameters to add it all one function and inserting it all in a webdriver.ChromeOptions object to the parameter wont help that much since if you have already configured an webdriver.ChromeOptions you might as well add it to a selenium driver and pass it to the set_driver() function. This way you have more flexibility with initialization of the driver parameters.

[mherrmann]

I've added an options parameter to start_chrome now. Please see release 3.0.2.